Bug 1492850 - Remove places where headers are printed

There's one place where some (unused?) debug code prints out headers without using Bugzilla->cgi, and testagent.cgi which does the same. The first thing is removed and testagent.cgi is also removed, with its route handled by a simple route.

diff --git a/Bugzilla/Quantum.pm b/Bugzilla/Quantum.pm
index d2352f6d88d8e4836760220eb8b9cf25ddd2731d..8af06c47741c2559a0e29e15e261f683c3db91bd 100644 (file)
--- a/Bugzilla/Quantum.pm
+++ b/Bugzilla/Quantum.pm
@@ -63,6 +63,10 @@ sub startup {
     $r->any('/')->to('CGI#index_cgi');
     $r->any('/bug/<id:num>')->to('CGI#show_bug_cgi');
     $r->any('/<id:num>')->to('CGI#show_bug_cgi');
+    $r->get('/testagent.cgi' => sub {
+        my $c = shift;
+        $c->render(text => "OK Mojolicious");
+    });
 
     $r->any('/rest')->to('CGI#rest_cgi');
     $r->any('/rest.cgi/*PATH_INFO')->to( 'CGI#rest_cgi' => { PATH_INFO => '' } );

diff --git a/extensions/BMO/lib/Reports/ReleaseTracking.pm b/extensions/BMO/lib/Reports/ReleaseTracking.pm
index 42ef24b4769357fa29b07220aa89de0056bb3447..9fba1e14b07ae7fbff19b90bce6eb2ed9c09e1dd 100644 (file)
--- a/extensions/BMO/lib/Reports/ReleaseTracking.pm
+++ b/extensions/BMO/lib/Reports/ReleaseTracking.pm
@@ -421,16 +421,6 @@ sub report {
 
         $query .= join("\nAND ", @where);
 
-        if ($input->{debug}) {
-            print "Content-Type: text/plain\n\n";
-            $query =~ s/\?/\000/g;
-            foreach my $param (@params) {
-                $query =~ s/\000/'$param'/;
-            }
-            print "$query\n";
-            exit;
-        }
-
         my $bugs = $dbh->selectcol_arrayref($query, undef, @params);
         push @$bugs, 0 unless @$bugs;
 

diff --git a/testagent.cgi b/testagent.cgi
deleted file mode 100755 (executable)
index a1c200e..0000000
--- a/testagent.cgi
+++ /dev/null
@@ -1,26 +0,0 @@
-#!/usr/bin/perl -T
-# -*- Mode: perl; indent-tabs-mode: nil -*-
-#
-# The contents of this file are subject to the Mozilla Public
-# License Version 1.1 (the "License"); you may not use this file
-# except in compliance with the License. You may obtain a copy of
-# the License at http://www.mozilla.org/MPL/
-#
-# Software distributed under the License is distributed on an "AS
-# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
-# implied. See the License for the specific language governing
-# rights and limitations under the License.
-#
-# Contributor(s): Joel Peshkin <bugreport@peshkin.net>
-
-# This script is used by servertest.pl to confirm that cgi scripts
-# are being run instead of shown. This script does not rely on database access
-# or correct params.
-
-use 5.10.1;
-use strict;
-use warnings;
-print "content-type:text/plain\n\n";
-print "OK " . ($::ENV{MOD_PERL} || "mod_cgi") . "\n";
-exit;
-