]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
drop a broken x86 patch
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Apr 2018 10:50:18 +0000 (12:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Apr 2018 10:50:18 +0000 (12:50 +0200)
queue-3.18/series
queue-3.18/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch [deleted file]
queue-4.4/series
queue-4.4/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch [deleted file]
queue-4.9/series
queue-4.9/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch [deleted file]

index d725f0f15e90e12ecb14d708655bb46d441a8373..73ee291b59d15dd6fc9734e178697518a99e4105 100644 (file)
@@ -1,3 +1,2 @@
 media-v4l2-compat-ioctl32-don-t-oops-on-overlay.patch
 parisc-fix-out-of-array-access-in-match_pci_device.patch
-x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
diff --git a/queue-3.18/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch b/queue-3.18/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
deleted file mode 100644 (file)
index a50ed2b..0000000
+++ /dev/null
@@ -1,95 +0,0 @@
-From 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 Mon Sep 17 00:00:00 2001
-From: Baoquan He <bhe@redhat.com>
-Date: Wed, 14 Feb 2018 13:46:53 +0800
-Subject: x86/apic: Fix restoring boot IRQ mode in reboot and kexec/kdump
-
-From: Baoquan He <bhe@redhat.com>
-
-commit 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 upstream.
-
-This is a regression fix.
-
-Before, to fix erratum AVR31, the following commit:
-
-  522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-
-... moved the lapic_shutdown() call to after disable_IO_APIC() in the reboot
-and kexec/kdump code paths.
-
-This introduced the following regression: disable_IO_APIC() not only clears
-the IO-APIC, but it also restores boot IRQ mode by setting the
-LAPIC/APIC/IMCR, calling lapic_shutdown() after disable_IO_APIC() will
-disable LAPIC and ruin the possible virtual wire mode setting which
-the code has been trying to do all along.
-
-The consequence is that a KVM guest kernel always prints the warning below
-during kexec/kdump as the kernel boots up:
-
-  [    0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 setup_local_APIC+0x228/0x330
-  [    ........]
-  [    0.001000] Call Trace:
-  [    0.001000]  apic_bsp_setup+0x56/0x74
-  [    0.001000]  x86_late_time_init+0x11/0x16
-  [    0.001000]  start_kernel+0x3c9/0x486
-  [    0.001000]  secondary_startup_64+0xa5/0xb0
-  [    ........]
-  [    0.001000] masked ExtINT on CPU#0
-
-To fix this, just call clear_IO_APIC() to stop the IO-APIC where
-disable_IO_APIC() was called, and call restore_boot_irq_mode() to
-restore boot IRQ mode before a reboot or a kexec/kdump jump.
-
-Signed-off-by: Baoquan He <bhe@redhat.com>
-Reviewed-by: Eric W. Biederman <ebiederm@xmission.com>
-Cc: Linus Torvalds <torvalds@linux-foundation.org>
-Cc: Peter Zijlstra <peterz@infradead.org>
-Cc: Thomas Gleixner <tglx@linutronix.de>
-Cc: douly.fnst@cn.fujitsu.com
-Cc: joro@8bytes.org
-Cc: prarit@redhat.com
-Cc: stable@vger.kernel.org
-Cc: uobergfe@redhat.com
-Fixes: commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-Link: http://lkml.kernel.org/r/20180214054656.3780-4-bhe@redhat.com
-[ Rewrote the changelog. ]
-Signed-off-by: Ingo Molnar <mingo@kernel.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- arch/x86/kernel/crash.c  |    3 ++-
- arch/x86/kernel/reboot.c |    3 ++-
- 2 files changed, 4 insertions(+), 2 deletions(-)
-
---- a/arch/x86/kernel/crash.c
-+++ b/arch/x86/kernel/crash.c
-@@ -173,9 +173,10 @@ void native_machine_crash_shutdown(struc
- #ifdef CONFIG_X86_IO_APIC
-       /* Prevent crash_kexec() from deadlocking on ioapic_lock. */
-       ioapic_zap_locks();
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();
- #endif
---- a/arch/x86/kernel/reboot.c
-+++ b/arch/x86/kernel/reboot.c
-@@ -606,7 +606,7 @@ void native_machine_shutdown(void)
-        * Even without the erratum, it still makes sense to quiet IO APIC
-        * before disabling Local APIC.
-        */
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
- #ifdef CONFIG_SMP
-@@ -620,6 +620,7 @@ void native_machine_shutdown(void)
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();
index da1f8b04fda7b753dbcc3e32402313686661e23e..23cd9513d3a9ab79617e3ec2deb150bf951042ff 100644 (file)
@@ -5,4 +5,3 @@ perf-intel-pt-fix-sync_switch.patch
 perf-intel-pt-fix-error-recovery-from-missing-tip-packet.patch
 perf-intel-pt-fix-timestamp-following-overflow.patch
 radeon-hide-pointless-warning-when-compile-testing.patch
-x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
diff --git a/queue-4.4/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch b/queue-4.4/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
deleted file mode 100644 (file)
index 0437bcb..0000000
+++ /dev/null
@@ -1,95 +0,0 @@
-From 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 Mon Sep 17 00:00:00 2001
-From: Baoquan He <bhe@redhat.com>
-Date: Wed, 14 Feb 2018 13:46:53 +0800
-Subject: x86/apic: Fix restoring boot IRQ mode in reboot and kexec/kdump
-
-From: Baoquan He <bhe@redhat.com>
-
-commit 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 upstream.
-
-This is a regression fix.
-
-Before, to fix erratum AVR31, the following commit:
-
-  522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-
-... moved the lapic_shutdown() call to after disable_IO_APIC() in the reboot
-and kexec/kdump code paths.
-
-This introduced the following regression: disable_IO_APIC() not only clears
-the IO-APIC, but it also restores boot IRQ mode by setting the
-LAPIC/APIC/IMCR, calling lapic_shutdown() after disable_IO_APIC() will
-disable LAPIC and ruin the possible virtual wire mode setting which
-the code has been trying to do all along.
-
-The consequence is that a KVM guest kernel always prints the warning below
-during kexec/kdump as the kernel boots up:
-
-  [    0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 setup_local_APIC+0x228/0x330
-  [    ........]
-  [    0.001000] Call Trace:
-  [    0.001000]  apic_bsp_setup+0x56/0x74
-  [    0.001000]  x86_late_time_init+0x11/0x16
-  [    0.001000]  start_kernel+0x3c9/0x486
-  [    0.001000]  secondary_startup_64+0xa5/0xb0
-  [    ........]
-  [    0.001000] masked ExtINT on CPU#0
-
-To fix this, just call clear_IO_APIC() to stop the IO-APIC where
-disable_IO_APIC() was called, and call restore_boot_irq_mode() to
-restore boot IRQ mode before a reboot or a kexec/kdump jump.
-
-Signed-off-by: Baoquan He <bhe@redhat.com>
-Reviewed-by: Eric W. Biederman <ebiederm@xmission.com>
-Cc: Linus Torvalds <torvalds@linux-foundation.org>
-Cc: Peter Zijlstra <peterz@infradead.org>
-Cc: Thomas Gleixner <tglx@linutronix.de>
-Cc: douly.fnst@cn.fujitsu.com
-Cc: joro@8bytes.org
-Cc: prarit@redhat.com
-Cc: stable@vger.kernel.org
-Cc: uobergfe@redhat.com
-Fixes: commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-Link: http://lkml.kernel.org/r/20180214054656.3780-4-bhe@redhat.com
-[ Rewrote the changelog. ]
-Signed-off-by: Ingo Molnar <mingo@kernel.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- arch/x86/kernel/crash.c  |    3 ++-
- arch/x86/kernel/reboot.c |    3 ++-
- 2 files changed, 4 insertions(+), 2 deletions(-)
-
---- a/arch/x86/kernel/crash.c
-+++ b/arch/x86/kernel/crash.c
-@@ -172,9 +172,10 @@ void native_machine_crash_shutdown(struc
- #ifdef CONFIG_X86_IO_APIC
-       /* Prevent crash_kexec() from deadlocking on ioapic_lock. */
-       ioapic_zap_locks();
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();
- #endif
---- a/arch/x86/kernel/reboot.c
-+++ b/arch/x86/kernel/reboot.c
-@@ -619,7 +619,7 @@ void native_machine_shutdown(void)
-        * Even without the erratum, it still makes sense to quiet IO APIC
-        * before disabling Local APIC.
-        */
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
- #ifdef CONFIG_SMP
-@@ -633,6 +633,7 @@ void native_machine_shutdown(void)
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();
index 6da36037b43a37a7df4ea7febc36419c272c4996..ffbd02068553fbbd2b37149a8a94de3a11d54371 100644 (file)
@@ -7,4 +7,3 @@ perf-intel-pt-fix-error-recovery-from-missing-tip-packet.patch
 perf-intel-pt-fix-timestamp-following-overflow.patch
 perf-core-fix-use-after-free-in-uprobe_perf_close.patch
 radeon-hide-pointless-warning-when-compile-testing.patch
-x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
diff --git a/queue-4.9/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch b/queue-4.9/x86-apic-fix-restoring-boot-irq-mode-in-reboot-and-kexec-kdump.patch
deleted file mode 100644 (file)
index 21a96c8..0000000
+++ /dev/null
@@ -1,95 +0,0 @@
-From 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 Mon Sep 17 00:00:00 2001
-From: Baoquan He <bhe@redhat.com>
-Date: Wed, 14 Feb 2018 13:46:53 +0800
-Subject: x86/apic: Fix restoring boot IRQ mode in reboot and kexec/kdump
-
-From: Baoquan He <bhe@redhat.com>
-
-commit 339b2ae0cd5d4a58f9efe06e4ee36adbeca59228 upstream.
-
-This is a regression fix.
-
-Before, to fix erratum AVR31, the following commit:
-
-  522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-
-... moved the lapic_shutdown() call to after disable_IO_APIC() in the reboot
-and kexec/kdump code paths.
-
-This introduced the following regression: disable_IO_APIC() not only clears
-the IO-APIC, but it also restores boot IRQ mode by setting the
-LAPIC/APIC/IMCR, calling lapic_shutdown() after disable_IO_APIC() will
-disable LAPIC and ruin the possible virtual wire mode setting which
-the code has been trying to do all along.
-
-The consequence is that a KVM guest kernel always prints the warning below
-during kexec/kdump as the kernel boots up:
-
-  [    0.001000] WARNING: CPU: 0 PID: 0 at arch/x86/kernel/apic/apic.c:1467 setup_local_APIC+0x228/0x330
-  [    ........]
-  [    0.001000] Call Trace:
-  [    0.001000]  apic_bsp_setup+0x56/0x74
-  [    0.001000]  x86_late_time_init+0x11/0x16
-  [    0.001000]  start_kernel+0x3c9/0x486
-  [    0.001000]  secondary_startup_64+0xa5/0xb0
-  [    ........]
-  [    0.001000] masked ExtINT on CPU#0
-
-To fix this, just call clear_IO_APIC() to stop the IO-APIC where
-disable_IO_APIC() was called, and call restore_boot_irq_mode() to
-restore boot IRQ mode before a reboot or a kexec/kdump jump.
-
-Signed-off-by: Baoquan He <bhe@redhat.com>
-Reviewed-by: Eric W. Biederman <ebiederm@xmission.com>
-Cc: Linus Torvalds <torvalds@linux-foundation.org>
-Cc: Peter Zijlstra <peterz@infradead.org>
-Cc: Thomas Gleixner <tglx@linutronix.de>
-Cc: douly.fnst@cn.fujitsu.com
-Cc: joro@8bytes.org
-Cc: prarit@redhat.com
-Cc: stable@vger.kernel.org
-Cc: uobergfe@redhat.com
-Fixes: commit 522e66464467 ("x86/apic: Disable I/O APIC before shutdown of the local APIC")
-Link: http://lkml.kernel.org/r/20180214054656.3780-4-bhe@redhat.com
-[ Rewrote the changelog. ]
-Signed-off-by: Ingo Molnar <mingo@kernel.org>
-Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
----
- arch/x86/kernel/crash.c  |    3 ++-
- arch/x86/kernel/reboot.c |    3 ++-
- 2 files changed, 4 insertions(+), 2 deletions(-)
-
---- a/arch/x86/kernel/crash.c
-+++ b/arch/x86/kernel/crash.c
-@@ -198,9 +198,10 @@ void native_machine_crash_shutdown(struc
- #ifdef CONFIG_X86_IO_APIC
-       /* Prevent crash_kexec() from deadlocking on ioapic_lock. */
-       ioapic_zap_locks();
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();
- #endif
---- a/arch/x86/kernel/reboot.c
-+++ b/arch/x86/kernel/reboot.c
-@@ -665,7 +665,7 @@ void native_machine_shutdown(void)
-        * Even without the erratum, it still makes sense to quiet IO APIC
-        * before disabling Local APIC.
-        */
--      disable_IO_APIC();
-+      clear_IO_APIC();
- #endif
- #ifdef CONFIG_SMP
-@@ -679,6 +679,7 @@ void native_machine_shutdown(void)
- #endif
-       lapic_shutdown();
-+      restore_boot_irq_mode();
- #ifdef CONFIG_HPET_TIMER
-       hpet_disable();