]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
IB/mthca: Adjust buddy->bits allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:12:09 +0000 (23:12 -0700)
committerLeon Romanovsky <leon@kernel.org>
Sun, 27 Apr 2025 11:50:52 +0000 (07:50 -0400)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "unsigned long **", but the returned type will be
"long **". These are the same allocation size (pointer size), but the
types do not match. Adjust the allocation type to match the assignment.

Signed-off-by: Kees Cook <kees@kernel.org>
Link: https://patch.msgid.link/20250426061208.work.000-kees@kernel.org
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mthca/mthca_mr.c

index 192f83fd7c8a5da081a07080dd9f2cf42db62bea..dacb8ceeebe05214909a8c76d0bd9c895a8ca282 100644 (file)
@@ -144,7 +144,7 @@ static int mthca_buddy_init(struct mthca_buddy *buddy, int max_order)
        buddy->max_order = max_order;
        spin_lock_init(&buddy->lock);
 
-       buddy->bits = kcalloc(buddy->max_order + 1, sizeof(long *),
+       buddy->bits = kcalloc(buddy->max_order + 1, sizeof(*buddy->bits),
                              GFP_KERNEL);
        buddy->num_free = kcalloc((buddy->max_order + 1), sizeof *buddy->num_free,
                                  GFP_KERNEL);