]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
target_core_configfs: avoid pointless cred reference count bump
authorChristian Brauner <brauner@kernel.org>
Mon, 25 Nov 2024 14:10:05 +0000 (15:10 +0100)
committerChristian Brauner <brauner@kernel.org>
Mon, 2 Dec 2024 10:25:10 +0000 (11:25 +0100)
The creds are allocated via prepare_kernel_cred() which has already
taken a reference.

Link: https://lore.kernel.org/r/20241125-work-cred-v2-9-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
drivers/target/target_core_configfs.c

index ec7a5598719397da5cadfed12a05ca8eb81e46a9..c40217f44b1bc53d149e8d5ea12c0e5297373800 100644 (file)
@@ -3756,9 +3756,9 @@ static int __init target_core_init_configfs(void)
                ret = -ENOMEM;
                goto out;
        }
-       old_cred = override_creds(get_new_cred(kern_cred));
+       old_cred = override_creds(kern_cred);
        target_init_dbroot();
-       put_cred(revert_creds(old_cred));
+       revert_creds(old_cred);
        put_cred(kern_cred);
 
        return 0;