]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mt76: mt7996: fix memory leak on mt7996_mcu_sta_key_tlv error
authorFelix Fietkau <nbd@nbd.name>
Mon, 15 Sep 2025 07:59:00 +0000 (09:59 +0200)
committerFelix Fietkau <nbd@nbd.name>
Mon, 15 Sep 2025 11:23:01 +0000 (13:23 +0200)
Free the allocated skb on error

Link: https://patch.msgid.link/20250915075910.47558-5-nbd@nbd.name
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c

index 5c16e4b780adb4f22d941041b1e11fe165f01729..5707e6b59aeaf064d4076f3abc2dab2959312aa3 100644 (file)
@@ -2614,8 +2614,10 @@ int mt7996_mcu_add_key(struct mt76_dev *dev, struct ieee80211_vif *vif,
                return PTR_ERR(skb);
 
        ret = mt7996_mcu_sta_key_tlv(wcid, skb, key, cmd);
-       if (ret)
+       if (ret) {
+               dev_kfree_skb(skb);
                return ret;
+       }
 
        return mt76_mcu_skb_send_msg(dev, skb, mcu_cmd, true);
 }