[#3986] addressed review comments

diff --git a/ChangeLog b/ChangeLog
index 3dde8cb10e3c45e1f6c4a5a966eb15b5603d32ff..840e8bedc6c2e75b488b0f070f38cde9296114a3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2392.  [func]          razvan
+       Reject 'config-set' and 'config-reload' commands when lease
+       file cleanup process is running.
+       (Gitlab #3986)
+
 Kea 3.1.1 (development) released on September 27, 2025
 
 2391.  [bug]           fdupont

diff --git a/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc b/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
index ab0800d145f3e9989bc589419cbb89571cbb23ec..e5a314b30244776240ee029053afc2fa64442d3f 100644 (file)
--- a/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
+++ b/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
@@ -1809,7 +1809,7 @@ TEST_F(CtrlChannelDhcpv4SrvTest, configReloadBrokenFile) {
     ::remove("test7.json");
 }
 
-// Tests if config-reload attempts to reload a file while LFC is running
+// Check that the "config-reload" fails when LFC is running.
 TEST_F(CtrlChannelDhcpv4SrvTest, configReloadLFCRunning) {
     createUnixChannelServer();
     std::string response;

diff --git a/src/bin/dhcp4/tests/http_control_socket_unittest.cc b/src/bin/dhcp4/tests/http_control_socket_unittest.cc
index 947482be549ea439f39b1df7ab268ff63df63b53..48579a744a11beaf72ec7a447142c4eec0f3a56d 100644 (file)
--- a/src/bin/dhcp4/tests/http_control_socket_unittest.cc
+++ b/src/bin/dhcp4/tests/http_control_socket_unittest.cc
@@ -532,7 +532,7 @@ public:
     // file is not a valid JSON.
     void testConfigReloadBrokenFile();
 
-    // Tests if config-reload attempts to reload a file while LFC is running.
+    // Tests if config-reload fails to reload a file while LFC is running.
     void testConfigReloadLFCRunning();
 
     // Tests if config-reload attempts to reload a file and reports that the
@@ -2827,7 +2827,7 @@ TEST_F(HttpsCtrlChannelDhcpv4Test, configReloadBrokenFile) {
     testConfigReloadBrokenFile();
 }
 
-// Tests if config-reload attempts to reload a file while LFC is running.
+// Check that the "config-reload" fails when LFC is running.
 void
 BaseCtrlChannelDhcpv4Test::testConfigReloadLFCRunning() {
     createHttpChannelServer();

diff --git a/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc b/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
index d6ca8608c874314f617d8a98ff4f7b97453aa357..f0d5eac6365aac15a1ace337b992237d6c178108 100644 (file)
--- a/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
+++ b/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
@@ -1813,7 +1813,7 @@ TEST_F(CtrlChannelDhcpv6SrvTest, configReloadBrokenFile) {
     ::remove("test7.json");
 }
 
-// Tests if config-reload attempts to reload a file while LFC is running
+// Check that the "config-reload" fails when LFC is running.
 TEST_F(CtrlChannelDhcpv6SrvTest, configReloadLFCRunning) {
     createUnixChannelServer();
     std::string response;

diff --git a/src/bin/dhcp6/tests/http_control_socket_unittest.cc b/src/bin/dhcp6/tests/http_control_socket_unittest.cc
index 1fc1bfc792a1a806b249c2e2fc544d27624be8b4..06ba22761eb9c68e2db62ca2ad2f19c20c3c6ecf 100644 (file)
--- a/src/bin/dhcp6/tests/http_control_socket_unittest.cc
+++ b/src/bin/dhcp6/tests/http_control_socket_unittest.cc
@@ -543,7 +543,7 @@ public:
     // file is not a valid JSON.
     void testConfigReloadBrokenFile();
 
-    // Tests if config-reload attempts to reload a file while LFC is running.
+    // Tests if config-reload fails to reload a file while LFC is running.
     void testConfigReloadLFCRunning();
 
     // Tests if config-reload attempts to reload a file and reports that the
@@ -2827,7 +2827,7 @@ TEST_F(HttpsCtrlChannelDhcpv6Test, configReloadBrokenFile) {
     testConfigReloadBrokenFile();
 }
 
-// Tests if config-reload attempts to reload a file while LFC is running.
+// Check that the "config-reload" fails when LFC is running.
 void
 BaseCtrlChannelDhcpv6Test::testConfigReloadLFCRunning() {
     createHttpChannelServer();