]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
jfs: compare old and new mode before setting update_mode flag
authorChengguang Xu <cgxu519@gmx.com>
Sat, 24 Nov 2018 09:40:44 +0000 (17:40 +0800)
committerDave Kleikamp <dave.kleikamp@oracle.com>
Thu, 10 Jan 2019 16:05:41 +0000 (10:05 -0600)
If new mode is the same as old mode we don't have to reset
inode mode in the rest of the code, so compare old and new
mode before setting update_mode flag.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
fs/jfs/acl.c

index 8c06a6ea862d8004982c493c9b3693a928cec2ad..ebb299003a5b7750ebf4d68f0d3551198e921e22 100644 (file)
@@ -117,7 +117,8 @@ int jfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
                rc = posix_acl_update_mode(inode, &mode, &acl);
                if (rc)
                        goto end_tx;
-               update_mode = 1;
+               if (mode != inode->i_mode)
+                       update_mode = 1;
        }
        rc = __jfs_set_acl(tid, inode, type, acl);
        if (!rc) {