]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mac80211: cancel color change finalize work when link is stopped
authorMichael-CY Lee <michael-cy.lee@mediatek.com>
Fri, 5 Jul 2024 07:43:26 +0000 (15:43 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 8 Jul 2024 16:28:47 +0000 (18:28 +0200)
The color change finalize work might be called after the link is
stopped, which might lead to a kernel crash.

Signed-off-by: Michael-CY Lee <michael-cy.lee@mediatek.com>
Link: https://patch.msgid.link/20240705074326.11172-1-michael-cy.lee@mediatek.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/link.c

index 2e6e92defbca65a699f75ea2a07dc0a3aeefdfe5..1a211b8d40573a2d3b15b46c2dc7ef4ce1f48d40 100644 (file)
@@ -71,6 +71,8 @@ void ieee80211_link_stop(struct ieee80211_link_data *link)
                ieee80211_mgd_stop_link(link);
 
        cancel_delayed_work_sync(&link->color_collision_detect_work);
+       wiphy_work_cancel(link->sdata->local->hw.wiphy,
+                         &link->color_change_finalize_work);
        wiphy_work_cancel(link->sdata->local->hw.wiphy,
                          &link->csa.finalize_work);
        ieee80211_link_release_channel(link);