]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: qcom: gcc-ipq5018: fix register offset for GCC_UBI0_AXI_ARES reset
authorGabor Juhos <j4g8y7@gmail.com>
Sun, 25 Feb 2024 17:32:56 +0000 (18:32 +0100)
committerBjorn Andersson <andersson@kernel.org>
Mon, 4 Mar 2024 04:00:49 +0000 (20:00 -0800)
The current register offset used for the GCC_UBI0_AXI_ARES reset
seems wrong. Or at least, the downstream driver uses [1] the same
offset which is used for other the GCC_UBI0_*_ARES resets.

Change the code to use the same offset used in the downstream
driver and also specify the reset bit explicitly to use the
same format as the followup entries.

1. https://git.codelinaro.org/clo/qsdk/oss/kernel/linux-ipq-5.4/-/blob/NHSS.QSDK.12.4.r4/drivers/clk/qcom/gcc-ipq5018.c?ref_type=heads#L3773

Fixes: e3fdbef1bab8 ("clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
Link: https://lore.kernel.org/r/20240225-gcc-ipq5018-register-fixes-v1-3-3c191404d9f0@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/clk/qcom/gcc-ipq5018.c

index 5437b66638d412b03818c5e01354ab5acd5289f9..c1732d70e3a2357091355e6f577f5e74ccab3b83 100644 (file)
@@ -3635,7 +3635,7 @@ static const struct qcom_reset_map gcc_ipq5018_resets[] = {
        [GCC_SYSTEM_NOC_BCR] = { 0x26000, 0 },
        [GCC_TCSR_BCR] = { 0x28000, 0 },
        [GCC_TLMM_BCR] = { 0x34000, 0 },
-       [GCC_UBI0_AXI_ARES] = { 0x680},
+       [GCC_UBI0_AXI_ARES] = { 0x68010, 0 },
        [GCC_UBI0_AHB_ARES] = { 0x68010, 1 },
        [GCC_UBI0_NC_AXI_ARES] = { 0x68010, 2 },
        [GCC_UBI0_DBG_ARES] = { 0x68010, 3 },