]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: pci: Properly cleanup resource
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>
Mon, 19 Mar 2018 20:07:35 +0000 (13:07 -0700)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:32 +0000 (21:36 -0400)
[ Upstream commit cabdf83dadfb3d83eec31e0f0638a92dbd716435 ]

Platform device is allocated before adding resources. Make sure to
properly cleanup on error case.

Cc: <stable@vger.kernel.org>
Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()")
Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/usb/dwc3/dwc3-pci.c

index c702f5d941d9d15cfe4a6823ef9faec569cad113..01816e8411fccc48ef3299c46080b8113b47f247 100644 (file)
@@ -124,7 +124,7 @@ static int dwc3_pci_probe(struct pci_dev *pci,
        ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res));
        if (ret) {
                dev_err(dev, "couldn't add resources to dwc3 device\n");
-               return ret;
+               goto err;
        }
 
        pci_set_drvdata(pci, dwc3);