]> git.ipfire.org Git - thirdparty/git.git/commitdiff
tr2: remove NEEDSWORK comment for "non-procfs" implementations
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Fri, 27 Aug 2021 08:02:13 +0000 (10:02 +0200)
committerJunio C Hamano <gitster@pobox.com>
Tue, 7 Sep 2021 18:07:59 +0000 (11:07 -0700)
I'm fairly sure that there is no way on Linux to inspect the process
tree without using procfs, any tool such as ps(1), top(1) etc. that
shows this sort of information ultimately looks the information up in
procfs.

So let's remove this comment added in 2f732bf15e6 (tr2: log parent
process name, 2021-07-21), it's setting us up for an impossible task.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/linux/procinfo.c

index 578fed4cd31bdb80fc42456323881e54c62e49c7..15a89676c7a618a2e519219c7757bbb9eb6dc5d2 100644 (file)
@@ -25,7 +25,6 @@ static void get_ancestry_names(struct strvec *names)
        }
 
        return;
-       /* NEEDSWORK: add non-procfs-linux implementations here */
 }
 
 void trace2_collect_process_info(enum trace2_process_info_reason reason)