]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers"
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 10 Dec 2024 11:14:44 +0000 (12:14 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 19 Dec 2024 18:44:30 +0000 (12:44 -0600)
This reverts commit f042bc234c2e00764b8aa2c9e2f8177cdc63f664.

A recent change enabling role switching for the x1e80100 USB-C
controllers breaks UCSI and DisplayPort Alternate Mode when the
controllers are in host mode:

ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: PPM init failed, stop trying

As enabling OTG mode currently breaks SuperSpeed hotplug and suspend,
and with retimer (and orientation detection) support not even merged
yet, let's revert at least until we have stable host mode in mainline.

Fixes: f042bc234c2e ("arm64: dts: qcom: x1e80100: enable OTG on USB-C controllers")
Reported-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/all/hw2pdof4ajadjsjrb44f2q4cz4yh5qcqz5d3l7gjt2koycqs3k@xx5xvd26uyef
Link: https://lore.kernel.org/lkml/Z1gbyXk-SktGjL6-@hovoldconsulting.com/
Cc: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241210111444.26240-4-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100.dtsi

index f1a1e63f8ebcfe5d6d837c9555414898bc0b4076..7e4f46ad8eddad8cb3817d4cac555b4ba68110c0 100644 (file)
 
                                dma-coherent;
 
-                               usb-role-switch;
-
                                ports {
                                        #address-cells = <1>;
                                        #size-cells = <0>;
 
                                dma-coherent;
 
-                               usb-role-switch;
-
                                ports {
                                        #address-cells = <1>;
                                        #size-cells = <0>;
 
                                dma-coherent;
 
-                               usb-role-switch;
-
                                ports {
                                        #address-cells = <1>;
                                        #size-cells = <0>;