]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
trace/pid_list: Change gfp flags in pid_list_fill_irq()
authorlevi.yun <yeoreum.yun@arm.com>
Thu, 4 Jul 2024 15:02:26 +0000 (16:02 +0100)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 15 Jul 2024 19:07:14 +0000 (15:07 -0400)
pid_list_fill_irq() runs via irq_work.
When CONFIG_PREEMPT_RT is disabled, it would run in irq_context.
so it shouldn't sleep while memory allocation.

Change gfp flags from GFP_KERNEL to GFP_NOWAIT to prevent sleep in
irq_work.

This change wouldn't impact functionality in practice because the worst-size
is 2K.

Cc: stable@goodmis.org
Fixes: 8d6e90983ade2 ("tracing: Create a sparse bitmask for pid filtering")
Link: https://lore.kernel.org/20240704150226.1359936-1-yeoreum.yun@arm.com
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: levi.yun <yeoreum.yun@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/pid_list.c

index 19b271a12c9979caa9e2ec2b8d0f385c41be5368..4966e6bbdf6f3786dede22abbcf9ac046b594139 100644 (file)
@@ -354,7 +354,7 @@ static void pid_list_refill_irq(struct irq_work *iwork)
        while (upper_count-- > 0) {
                union upper_chunk *chunk;
 
-               chunk = kzalloc(sizeof(*chunk), GFP_KERNEL);
+               chunk = kzalloc(sizeof(*chunk), GFP_NOWAIT);
                if (!chunk)
                        break;
                *upper_next = chunk;
@@ -365,7 +365,7 @@ static void pid_list_refill_irq(struct irq_work *iwork)
        while (lower_count-- > 0) {
                union lower_chunk *chunk;
 
-               chunk = kzalloc(sizeof(*chunk), GFP_KERNEL);
+               chunk = kzalloc(sizeof(*chunk), GFP_NOWAIT);
                if (!chunk)
                        break;
                *lower_next = chunk;