]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: storvsc: Don't report the host packet status as the hv status
authorRoman Kisel <romank@linux.microsoft.com>
Tue, 4 Mar 2025 00:09:40 +0000 (16:09 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 11 Mar 2025 01:18:56 +0000 (21:18 -0400)
The log statement reports the packet status code as the hv status code
which causes confusion when debugging as "hv" might refer to a hypervisor,
and sometimes to the host part of the Hyper-V virtualization stack.

Fix the name of the datum being logged to clearly indicate the component
reporting the error. Also log it in hexadecimal everywhere for consistency.

Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
Link: https://lore.kernel.org/r/20250304000940.9557-2-romank@linux.microsoft.com
Reviewed-by: Easwar Hariharan <eahariha@linux.microsoft.com>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c

index a8614e54544e59d4391ae8c2cf5682c5cfe74c08..35db061ae3ecdeaacf31b9198ef46a61c8f3cbf2 100644 (file)
@@ -776,7 +776,7 @@ static void  handle_multichannel_storage(struct hv_device *device, int max_chns)
 
        if (vstor_packet->operation != VSTOR_OPERATION_COMPLETE_IO ||
            vstor_packet->status != 0) {
-               dev_err(dev, "Failed to create sub-channel: op=%d, sts=%d\n",
+               dev_err(dev, "Failed to create sub-channel: op=%d, host=0x%x\n",
                        vstor_packet->operation, vstor_packet->status);
                return;
        }
@@ -1183,7 +1183,7 @@ static void storvsc_on_io_completion(struct storvsc_device *stor_device,
                        STORVSC_LOGGING_WARN : STORVSC_LOGGING_ERROR;
 
                storvsc_log_ratelimited(device, loglevel,
-                       "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x hv 0x%x\n",
+                       "tag#%d cmd 0x%x status: scsi 0x%x srb 0x%x host 0x%x\n",
                        scsi_cmd_to_rq(request->cmd)->tag,
                        stor_pkt->vm_srb.cdb[0],
                        vstor_packet->vm_srb.scsi_status,