]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
watchdog: mpc8xxx_wdt: Reload the watchdog timer when enabling the watchdog
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Tue, 12 Aug 2025 12:51:26 +0000 (14:51 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Fri, 12 Sep 2025 16:10:07 +0000 (18:10 +0200)
When the watchdog gets enabled with this driver, it leaves enough time
for the core watchdog subsystem to start pinging it. But when the
watchdog is already started by hardware or by the boot loader, little
time remains before it fires and it happens that the core watchdog
subsystem doesn't have time to start pinging it.

Until commit 19ce9490aa84 ("watchdog: mpc8xxx: use the core worker
function") pinging was managed by the driver itself and the watchdog
was immediately pinged by setting the timer expiry to 0.

So restore similar behaviour by pinging it when enabling it so that
if it was already enabled the watchdog timer counter is reloaded.

Fixes: 19ce9490aa84 ("watchdog: mpc8xxx: use the core worker function")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/mpc8xxx_wdt.c

index 867f9f311379719f7e647d61589afd08d6513250..a4b497ecfa20518414e44bbecf5449dc490e1e5c 100644 (file)
@@ -100,6 +100,8 @@ static int mpc8xxx_wdt_start(struct watchdog_device *w)
        ddata->swtc = tmp >> 16;
        set_bit(WDOG_HW_RUNNING, &ddata->wdd.status);
 
+       mpc8xxx_wdt_keepalive(ddata);
+
        return 0;
 }