]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
linkmode: Change return type of linkmode_andnot to bool
authorSimon Horman <horms@kernel.org>
Thu, 1 Aug 2024 20:00:03 +0000 (21:00 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Aug 2024 23:32:29 +0000 (16:32 -0700)
linkmode_andnot() simply returns the result of bitmap_andnot().
And the return type of bitmap_andnot() is bool.
So it makes sense for the return type of linkmode_andnot()
to also be bool.

I checked all call-sites and they either ignore the return
value or treat it as a bool.

Compile tested only.

Link: https://lore.kernel.org/netdev/68088998-4486-4930-90a4-96a32f08c490@lunn.ch/
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240801-linkfield-bowl-v1-1-d58f68967802@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/linkmode.h

index d94bfd9ac8cca272cf05da6fa30cec5c51cc90b9..3b9de09871f60300e4094d9ea4010224a29627f6 100644 (file)
@@ -37,8 +37,9 @@ static inline bool linkmode_empty(const unsigned long *src)
        return bitmap_empty(src, __ETHTOOL_LINK_MODE_MASK_NBITS);
 }
 
-static inline int linkmode_andnot(unsigned long *dst, const unsigned long *src1,
-                                 const unsigned long *src2)
+static inline bool linkmode_andnot(unsigned long *dst,
+                                  const unsigned long *src1,
+                                  const unsigned long *src2)
 {
        return bitmap_andnot(dst, src1, src2,  __ETHTOOL_LINK_MODE_MASK_NBITS);
 }