]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: amd: Add ACPI dependency to fix build error
authorYu-Chun Lin <eleanor15x@gmail.com>
Thu, 9 Jan 2025 17:15:47 +0000 (01:15 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 9 Jan 2025 17:22:23 +0000 (17:22 +0000)
As reported by the kernel test robot, the following error occurs:

   sound/soc/amd/yc/acp6x-mach.c: In function 'acp6x_probe':
>> sound/soc/amd/yc/acp6x-mach.c:573:15: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
     573 |         ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
         |               ^~~~~~~~~~~~~~~~~~~~~
         |               acpi_evaluate_object
   cc1: some warnings being treated as errors

The function 'acpi_evaluate_integer' and its prototype in 'acpi_bus.h'
are only available when 'CONFIG_ACPI' is enabled. Add a 'depends on ACPI'
directive in Kconfig to ensure proper compilation.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501090345.pBIDRTym-lkp@intel.com/
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
Link: https://patch.msgid.link/20250109171547.362412-1-eleanor15x@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/Kconfig

index c7590d4989bba5335e3afe8368e91de2bd089391..80352117827914ea99b22d96615530ee8816f161 100644 (file)
@@ -105,7 +105,7 @@ config SND_SOC_AMD_ACP6x
 config SND_SOC_AMD_YC_MACH
        tristate "AMD YC support for DMIC"
        select SND_SOC_DMIC
-       depends on SND_SOC_AMD_ACP6x
+       depends on SND_SOC_AMD_ACP6x && ACPI
        help
          This option enables machine driver for Yellow Carp platform
          using dmic. ACP IP has PDM Decoder block with DMA controller.