]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix memory leak in peer cache Digest exchange
authorAmos Jeffries <squid3@treenet.co.nz>
Tue, 14 Jan 2014 21:29:20 +0000 (10:29 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Tue, 14 Jan 2014 21:29:20 +0000 (10:29 +1300)
 Detected by Coverity Scan. Issue 1094115.

src/peer_digest.cc

index 60559dc4ce5291b1e467dfd15688d7a6d958621b..7bd4988862a020edec60fc42e4973fe643e7c3d8 100644 (file)
@@ -300,7 +300,7 @@ peerDigestRequest(PeerDigest * pd)
 {
     CachePeer *p = pd->peer;
     StoreEntry *e, *old_e;
-    char *url;
+    char *url = NULL;
     const cache_key *key;
     HttpRequest *req;
     DigestFetchState *fetch = NULL;
@@ -398,6 +398,8 @@ peerDigestRequest(PeerDigest * pd)
 
     storeClientCopy(fetch->sc, e, tempBuffer,
                     peerDigestHandleReply, fetch);
+
+    safe_free(url);
 }
 
 /* Handle the data copying .. */