]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
proc: Remove usage of the deprecated ida_simple_xx() API
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 8 Jun 2024 14:34:20 +0000 (16:34 +0200)
committerChristian Brauner <brauner@kernel.org>
Tue, 25 Jun 2024 09:15:47 +0000 (11:15 +0200)
ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_max() is inclusive. So a -1 has been added when needed.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/ae10003feb87d240163d0854de95f09e1f00be7d.1717855701.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/proc/generic.c

index 775ce0bcf08ce28954be8d6cec1b77c08c0bc722..c02f1e63f82d0947cf358aa6f23e4df99ab707b8 100644 (file)
@@ -202,8 +202,8 @@ int proc_alloc_inum(unsigned int *inum)
 {
        int i;
 
-       i = ida_simple_get(&proc_inum_ida, 0, UINT_MAX - PROC_DYNAMIC_FIRST + 1,
-                          GFP_KERNEL);
+       i = ida_alloc_max(&proc_inum_ida, UINT_MAX - PROC_DYNAMIC_FIRST,
+                         GFP_KERNEL);
        if (i < 0)
                return i;
 
@@ -213,7 +213,7 @@ int proc_alloc_inum(unsigned int *inum)
 
 void proc_free_inum(unsigned int inum)
 {
-       ida_simple_remove(&proc_inum_ida, inum - PROC_DYNAMIC_FIRST);
+       ida_free(&proc_inum_ida, inum - PROC_DYNAMIC_FIRST);
 }
 
 static int proc_misc_d_revalidate(struct dentry *dentry, unsigned int flags)