]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
riscv: Simplify base extension checks and direct boolean return
authorChin Yik Ming <yikming2222@gmail.com>
Wed, 29 Jan 2025 20:38:43 +0000 (04:38 +0800)
committerAlexandre Ghiti <alexghiti@rivosinc.com>
Tue, 18 Mar 2025 12:47:20 +0000 (12:47 +0000)
Reduce three lines checking to single line using a ternary conditional
expression for getting the base extension word. In addition, the
test_bit macro function already return a boolean which matches the
return type of the caller, so directly return the result of the test_bit
macro function.

Signed-off-by: Chin Yik Ming <yikming2222@gmail.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20250129203843.1136838-1-yikming2222@gmail.com
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
arch/riscv/kernel/cpufeature.c
arch/riscv/kernel/vendor_extensions.c

index ef34622902bf992e4d7437da116d194387bd9216..6ec9499e2cf27f459cb6e0dcceaa1d3f8994727b 100644 (file)
@@ -54,9 +54,7 @@ u32 thead_vlenb_of;
  */
 unsigned long riscv_isa_extension_base(const unsigned long *isa_bitmap)
 {
-       if (!isa_bitmap)
-               return riscv_isa[0];
-       return isa_bitmap[0];
+       return !isa_bitmap ? riscv_isa[0] : isa_bitmap[0];
 }
 EXPORT_SYMBOL_GPL(riscv_isa_extension_base);
 
@@ -77,7 +75,7 @@ bool __riscv_isa_extension_available(const unsigned long *isa_bitmap, unsigned i
        if (bit >= RISCV_ISA_EXT_MAX)
                return false;
 
-       return test_bit(bit, bmap) ? true : false;
+       return test_bit(bit, bmap);
 }
 EXPORT_SYMBOL_GPL(__riscv_isa_extension_available);
 
index a31ff84740ebc110fef13738f0f768db168d376a..9feb7f67a0a3905587b0070d4a194b4edd5efec6 100644 (file)
@@ -61,6 +61,6 @@ bool __riscv_isa_vendor_extension_available(int cpu, unsigned long vendor, unsig
        if (bit >= RISCV_ISA_VENDOR_EXT_MAX)
                return false;
 
-       return test_bit(bit, bmap->isa) ? true : false;
+       return test_bit(bit, bmap->isa);
 }
 EXPORT_SYMBOL_GPL(__riscv_isa_vendor_extension_available);