misc: syslog: Use CLOC_EXEC with _PATH_CONSOLE (BZ #17145)

The syslog open the '/dev/console' for LOG_CONS without O_CLOEXEC,
which might leak in multithread programs that call fork.

Checked on x86_64-linux-gnu.

diff --git a/misc/syslog.c b/misc/syslog.c
index 18330a373bf39fc89452442cc23c06762daad9f3..e228860d22fe080aaa09f08b1ed027bbdc5654ec 100644 (file)
--- a/misc/syslog.c
+++ b/misc/syslog.c
@@ -284,7 +284,8 @@ __vsyslog_internal(int pri, const char *fmt, va_list ap,
                 * syslogd failure.
                 */
                if (LogStat & LOG_CONS &&
-                   (fd = __open(_PATH_CONSOLE, O_WRONLY|O_NOCTTY, 0)) >= 0)
+                   (fd = __open(_PATH_CONSOLE, O_WRONLY|O_NOCTTY|O_CLOEXEC,
+                                0)) >= 0)
                  {
                    __dprintf (fd, "%s\r\n", buf + msgoff);
                    (void)__close(fd);