]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: rj54n1cb0c: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:14:59 +0000 (14:14 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./i2c/rj54n1cb0c.c:1361:4-11: WARNING: Consider using %pe to print PTR_ERR()
./i2c/rj54n1cb0c.c:1370:4-11: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/rj54n1cb0c.c

index 6dfc912168510fb1bd308f834911f9de705844b7..e95342d706c39a853e8c18de1ce447a5fa508565 100644 (file)
@@ -1357,8 +1357,8 @@ static int rj54n1_probe(struct i2c_client *client)
        rj54n1->pwup_gpio = gpiod_get_optional(&client->dev, "powerup",
                                               GPIOD_OUT_LOW);
        if (IS_ERR(rj54n1->pwup_gpio)) {
-               dev_info(&client->dev, "Unable to get GPIO \"powerup\": %ld\n",
-                        PTR_ERR(rj54n1->pwup_gpio));
+               dev_info(&client->dev, "Unable to get GPIO \"powerup\": %pe\n",
+                        rj54n1->pwup_gpio);
                ret = PTR_ERR(rj54n1->pwup_gpio);
                goto err_clk_put;
        }
@@ -1366,8 +1366,8 @@ static int rj54n1_probe(struct i2c_client *client)
        rj54n1->enable_gpio = gpiod_get_optional(&client->dev, "enable",
                                                 GPIOD_OUT_LOW);
        if (IS_ERR(rj54n1->enable_gpio)) {
-               dev_info(&client->dev, "Unable to get GPIO \"enable\": %ld\n",
-                        PTR_ERR(rj54n1->enable_gpio));
+               dev_info(&client->dev, "Unable to get GPIO \"enable\": %pe\n",
+                        rj54n1->enable_gpio);
                ret = PTR_ERR(rj54n1->enable_gpio);
                goto err_gpio_put;
        }