]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: s5k6a3: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:35 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:27 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/s5k6a3.c

index 0c2674115b7bd3a9772dde1681466b232ccae49a..4bf5f122b113b23e86b33a92b8fb77fbac40d03b 100644 (file)
@@ -292,9 +292,10 @@ static int s5k6a3_probe(struct i2c_client *client)
        mutex_init(&sensor->lock);
        sensor->dev = dev;
 
-       sensor->clock = devm_clk_get(sensor->dev, S5K6A3_CLK_NAME);
+       sensor->clock = devm_v4l2_sensor_clk_get(sensor->dev, S5K6A3_CLK_NAME);
        if (IS_ERR(sensor->clock))
-               return PTR_ERR(sensor->clock);
+               return dev_err_probe(sensor->dev, PTR_ERR(sensor->clock),
+                                    "failed to get extclk\n");
 
        sensor->gpio_reset = devm_gpiod_get(dev, NULL, GPIOD_OUT_HIGH);
        ret = PTR_ERR_OR_ZERO(sensor->gpio_reset);