]> git.ipfire.org Git - thirdparty/git.git/commitdiff
Merge branch 'sj/string-list-typefix' into seen
authorJunio C Hamano <gitster@pobox.com>
Tue, 24 Jun 2025 16:49:49 +0000 (09:49 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 24 Jun 2025 16:49:50 +0000 (09:49 -0700)
Code and test clean-up around string-list API.

Comments?

* sj/string-list-typefix:
  u-string-list: move "remove duplicates" test to "u-string-list.c"
  u-string-list: move "filter string" test to "u-string-list.c"
  u-string-list: move "test_split_in_place" to "u-string-list.c"
  u-string-list: move "test_split" into "u-string-list.c"
  string-list: enable sign compare warnings check
  string-list: return index directly when inserting an existing element
  string-list: remove unused "insert_at" parameter from add_entry
  string-list: fix sign compare warnings for loop iterator

1  2 
Makefile
t/meson.build

diff --cc Makefile
index 58ebb56b93fe8ef6d11b2987c62c2c96ff994720,60195537eb3da6797736ae7eee37cd169bb0025b..def2330a34a3d96fe8b8df11702fdd816223127d
+++ b/Makefile
@@@ -1374,9 -1363,8 +1374,10 @@@ CLAR_TEST_SUITES += u-reftable-tabl
  CLAR_TEST_SUITES += u-reftable-tree
  CLAR_TEST_SUITES += u-strbuf
  CLAR_TEST_SUITES += u-strcmp-offset
+ CLAR_TEST_SUITES += u-string-list
  CLAR_TEST_SUITES += u-strvec
 +CLAR_TEST_SUITES += u-trailer
 +CLAR_TEST_SUITES += u-urlmatch-normalization
  CLAR_TEST_PROG = $(UNIT_TEST_BIN)/unit-tests$(X)
  CLAR_TEST_OBJS = $(patsubst %,$(UNIT_TEST_DIR)/%.o,$(CLAR_TEST_SUITES))
  CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/clar/clar.o
diff --cc t/meson.build
index 07fa4682165e83ae6717535cdf3bf3b94278d199,39a6fdcd02fbcdc0e3a220b285a255b66dd7e765..e777ec804f9d664dc6d7a8eff3f7cfe35f11071a
@@@ -19,9 -11,8 +19,10 @@@ clar_test_suites = 
    'unit-tests/u-reftable-tree.c',
    'unit-tests/u-strbuf.c',
    'unit-tests/u-strcmp-offset.c',
+   'unit-tests/u-string-list.c',
    'unit-tests/u-strvec.c',
 +  'unit-tests/u-trailer.c',
 +  'unit-tests/u-urlmatch-normalization.c',
  ]
  
  clar_sources = [