]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ldb:tools: ldbsearch doesn't need ldb_qsort()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 12 Apr 2024 06:11:12 +0000 (18:11 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 7 May 2024 23:25:35 +0000 (23:25 +0000)
When the opaque context blob is not used, we might as well
use a real qsort().

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/tools/ldbsearch.c

index 374f2405e4738bc94b094f586d15d778168e8cde..a0c74b175fadb5f7ef6b341517454854ccf2302d 100644 (file)
@@ -45,8 +45,7 @@ static void usage(struct ldb_context *ldb)
 }
 
 static int do_compare_msg(struct ldb_message **el1,
-                         struct ldb_message **el2,
-                         void *opaque)
+                         struct ldb_message **el2)
 {
        return ldb_dn_compare((*el1)->dn, (*el2)->dn);
 }
@@ -269,7 +268,7 @@ again:
                unsigned int i;
 
                if (sctx->num_stored) {
-                       LDB_TYPESAFE_QSORT(sctx->store, sctx->num_stored, ldb, do_compare_msg);
+                       TYPESAFE_QSORT(sctx->store, sctx->num_stored, do_compare_msg);
                }
                for (i = 0; i < sctx->num_stored; i++) {
                        display_message(sctx->store[i], sctx);