cgroup: WQ_PERCPU added to alloc_workqueue users

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.
This lack of consistentcy cannot be addressed without refactoring the API.

alloc_workqueue() treats all queues as per-CPU by default, while unbound
workqueues must opt-in via WQ_UNBOUND.

This default is suboptimal: most workloads benefit from unbound queues,
allowing the scheduler to place worker threads where they’re needed and
reducing noise when CPUs are isolated.

This patch adds a new WQ_PERCPU flag to explicitly request the use of
the per-CPU behavior. Both flags coexist for one release cycle to allow
callers to transition their calls.

Once migration is complete, WQ_UNBOUND can be removed and unbound will
become the implicit default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU.

All existing users have been updated accordingly.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c
index 763343fbd5a174503aeedb9292c0a9f8764f3af7..0a23b65de013fc79b89459262a5fbce70c5eac13 100644 (file)
--- a/kernel/cgroup/cgroup-v1.c
+++ b/kernel/cgroup/cgroup-v1.c
@@ -1326,7 +1326,7 @@ static int __init cgroup1_wq_init(void)
         * Cap @max_active to 1 too.
         */
        cgroup_pidlist_destroy_wq = alloc_workqueue("cgroup_pidlist_destroy",
-                                                   0, 1);
+                                                   WQ_PERCPU, 1);
        BUG_ON(!cgroup_pidlist_destroy_wq);
        return 0;
 }

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 06a9b4a17d4172c38e3935e506aa14b5944651af..99d3b6c0f328c4a088cfe4e917c38872a73e1da4 100644 (file)
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -6346,7 +6346,7 @@ static int __init cgroup_wq_init(void)
         * We would prefer to do this in cgroup_init() above, but that
         * is called before init_workqueues(): so leave this until after.
         */
-       cgroup_destroy_wq = alloc_workqueue("cgroup_destroy", 0, 1);
+       cgroup_destroy_wq = alloc_workqueue("cgroup_destroy", WQ_PERCPU, 1);
        BUG_ON(!cgroup_destroy_wq);
        return 0;
 }