]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
mka: Fix an incorrect update of participant->to_use_sak
authorBadrish Adiga H R <badrish.adigahr@gmail.com>
Fri, 6 Jan 2017 12:17:51 +0000 (17:47 +0530)
committerJouni Malinen <j@w1.fi>
Mon, 6 Feb 2017 18:37:58 +0000 (20:37 +0200)
API ieee802_1x_mka_decode_dist_sak_body() wrongly puts
participant->to_use_sak to TRUE, if Distributed SAK Parameter Set of
length 0 is received. In MACsec PSK mode, this stale incorrect value can
create problems while re-establishing CA. In MACsec PSK mode, CA goes
down if interface goes down and ideally we should be able to
re-establish the CA once interface comes up.

Signed-off-by: Badrish Adiga H R <badrish.adigahr@gmail.com>
src/pae/ieee802_1x_kay.c

index 1004b32dca6f0eebc3e0df0c7964d589555fd4d2..79a6878d3ecfa4fc2466a63ce7cb66cccbe21cd8 100644 (file)
@@ -1559,7 +1559,7 @@ ieee802_1x_mka_decode_dist_sak_body(
                ieee802_1x_cp_connect_authenticated(kay->cp);
                ieee802_1x_cp_sm_step(kay->cp);
                wpa_printf(MSG_WARNING, "KaY:The Key server advise no MACsec");
-               participant->to_use_sak = TRUE;
+               participant->to_use_sak = FALSE;
                return 0;
        }