]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: psci: Fix refcount leak in psci_dt_init
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 18 Mar 2025 15:17:12 +0000 (23:17 +0800)
committerWill Deacon <will@kernel.org>
Tue, 29 Apr 2025 12:32:21 +0000 (13:32 +0100)
Fix a reference counter leak in psci_dt_init() where of_node_put(np) was
missing after of_find_matching_node_and_match() when np is unavailable.

Fixes: d09a0011ec0d ("drivers: psci: Allow PSCI node to be disabled")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20250318151712.28763-1-linmq006@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/firmware/psci/psci.c

index a1ebbe9b73b136218e9d9f9b8daa7756b3ab2fbe..38ca190d4a22d6e7e0f06420e8478a2b0ec2fe6f 100644 (file)
@@ -804,8 +804,10 @@ int __init psci_dt_init(void)
 
        np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np);
 
-       if (!np || !of_device_is_available(np))
+       if (!np || !of_device_is_available(np)) {
+               of_node_put(np);
                return -ENODEV;
+       }
 
        init_fn = (psci_initcall_t)matched_np->data;
        ret = init_fn(np);