]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: dsa: b53: prevent DIS_LEARNING access on BCM5325
authorÁlvaro Fernández Rojas <noltari@gmail.com>
Sat, 14 Jun 2025 07:59:55 +0000 (09:59 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jun 2025 00:52:17 +0000 (17:52 -0700)
BCM5325 doesn't implement DIS_LEARNING register so we should avoid reading
or writing it.

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Link: https://patch.msgid.link/20250614080000.1884236-10-noltari@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c

index c7c9501274482413868fff6fd4599cef5f02eaf5..daf7c1906711441105b646c9cac14f0f5f3c4a27 100644 (file)
@@ -593,6 +593,9 @@ static void b53_port_set_learning(struct b53_device *dev, int port,
 {
        u16 reg;
 
+       if (is5325(dev))
+               return;
+
        b53_read16(dev, B53_CTRL_PAGE, B53_DIS_LEARNING, &reg);
        if (learning)
                reg &= ~BIT(port);
@@ -2243,7 +2246,13 @@ int b53_br_flags_pre(struct dsa_switch *ds, int port,
                     struct switchdev_brport_flags flags,
                     struct netlink_ext_ack *extack)
 {
-       if (flags.mask & ~(BR_FLOOD | BR_MCAST_FLOOD | BR_LEARNING))
+       struct b53_device *dev = ds->priv;
+       unsigned long mask = (BR_FLOOD | BR_MCAST_FLOOD);
+
+       if (!is5325(dev))
+               mask |= BR_LEARNING;
+
+       if (flags.mask & ~mask)
                return -EINVAL;
 
        return 0;