Build errors after audit changes

diff --git a/src/comm/AcceptLimiter.cc b/src/comm/AcceptLimiter.cc
index cad3c324a002a799b86da8a2fdbb835b9301bc54..a3ce69935ae8b090e1580716939c3f592bf8aa32 100644 (file)
--- a/src/comm/AcceptLimiter.cc
+++ b/src/comm/AcceptLimiter.cc
@@ -41,7 +41,8 @@ Comm::AcceptLimiter::kick()
     debugs(5, 5, HERE << " size=" << deferred.size());
     while (deferred.size() > 0 && fdNFree() >= RESERVED_FD) {
         /* NP: shift() is equivalent to pop_front(). Giving us a FIFO queue. */
-        if ((ConnAcceptor *temp = deferred.shift()) != NULL) {
+        ConnAcceptor *temp = deferred.shift();
+        if (temp != NULL) {
             debugs(5, 5, HERE << " doing one.");
             temp->isLimited--;
             temp->acceptNext();

diff --git a/src/comm/ConnAcceptor.cc b/src/comm/ConnAcceptor.cc
index f10f14e1d0b1cff60ddef08571dcaa3cacbb86b0..41570942497617ec955ca565828ad1b445332628 100644 (file)
--- a/src/comm/ConnAcceptor.cc
+++ b/src/comm/ConnAcceptor.cc
@@ -259,7 +259,7 @@ Comm::ConnAcceptor::acceptNext()
 // XXX: obsolete comment?
 // NP: can't be a const function because syncWithComm() side effects hit theCallSub->callback().
 void
-Comm::ConnAcceptor::notify(comm_err_t flag, const Comm::ConnectionPointer &newConnDetails) const
+Comm::ConnAcceptor::notify(comm_err_t flag, const Comm::ConnectionPointer &newConnDetails)
 {
     // listener socket handlers just abandon the port with COMM_ERR_CLOSING
     // it should only happen when this object is deleted...

diff --git a/src/comm/ConnOpener.cc b/src/comm/ConnOpener.cc
index b94ef154f4a4cbf726bb7c78cdfb293652f3fd9e..7c6aa3fd6d7b262be46af1d34ee71b13e9d183d8 100644 (file)
--- a/src/comm/ConnOpener.cc
+++ b/src/comm/ConnOpener.cc
@@ -136,14 +136,12 @@ Comm::ConnOpener::start()
         }
     }
 
-    typedef CommCbMemFunT<Comm::ConnOpener, CommConnectCbParams> Dialer;
-    calls_.earlyAbort_ = asyncCall(5, 4, "Comm::ConnOpener::earlyAbort",
-                                   Dialer(this, &Comm::ConnOpener::earlyAbort));
+    typedef CommCbMemFunT<Comm::ConnOpener, CommConnectCbParams> abortDialer;
+    calls_.earlyAbort_ = JobCallback(5, 4, abortDialer, this, Comm::ConnOpener::earlyAbort);
     comm_add_close_handler(conn_->fd, calls_.earlyAbort_);
 
-    typedef CommCbMemFunT<Comm::ConnOpener, CommTimeoutCbParams> Dialer;
-    calls_.timeout_ = asyncCall(5, 4, "Comm::ConnOpener::timeout",
-                                Dialer(this, &Comm::ConnOpener::timeout));
+    typedef CommCbMemFunT<Comm::ConnOpener, CommTimeoutCbParams> timeoutDialer;
+    calls_.timeout_ = JobCallback(5, 4, timeoutDialer, this, Comm::ConnOpener::timeout);
     debugs(5, 3, HERE << conn_ << " timeout " << connectTimeout_);
     commSetTimeout(conn_->fd, connectTimeout_, calls_.timeout_);
 

diff --git a/src/comm/ConnOpener.h b/src/comm/ConnOpener.h
index 2a5c0c7c0bbd45d9528f09be0821b722602f896b..afb8731a92b2f1fc53926967526a1fbdc034bf0a 100644 (file)
--- a/src/comm/ConnOpener.h
+++ b/src/comm/ConnOpener.h
@@ -57,7 +57,7 @@ private:
     time_t connectTimeout_;
 
     /// time at which this series of connection attempts was started.
-    time_t connStart_;
+    time_t connectStart_;
 
     /// handles to calls which we may need to cancel.
     struct Calls {

diff --git a/src/comm/Connection.cc b/src/comm/Connection.cc
index d1bdc16d95927f8e773ae93806738371bc096a6f..b8987e82a7a7a40e442658ef300ded040a697b18 100644 (file)
--- a/src/comm/Connection.cc
+++ b/src/comm/Connection.cc
@@ -23,7 +23,8 @@ Comm::Connection::Connection() :
 Comm::Connection::~Connection()
 {
     close();
-    cbdataReferenceDone(getPeer());
+    if (getPeer())
+        cbdataReferenceDone(_peer);
 }
 
 Comm::ConnectionPointer
@@ -36,7 +37,7 @@ Comm::Connection::copyDetails() const
     c->peerType = peerType;
     c->tos = tos;
     c->flags = flags;
- 
+
     // ensure FD is not open in the new copy.
     c->fd = -1;
 
@@ -57,7 +58,7 @@ Comm::Connection::close()
     }
 }
 
-peer *
+peer * const
 Comm::Connection::getPeer() const
 {
     if (cbdataReferenceValid(_peer))