lib: simplify smbpasswd_sethexpwd() with hex_encode_buf()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source4/lib/samba3/smbpasswd.c b/source4/lib/samba3/smbpasswd.c
index 581c113e7c462aee9134cc6ea9ab076d364cd485..6f4d832ae2ba2a83da2b6a503261d599bb459d4f 100644 (file)
--- a/source4/lib/samba3/smbpasswd.c
+++ b/source4/lib/samba3/smbpasswd.c
@@ -89,14 +89,11 @@ char *smbpasswd_sethexpwd(TALLOC_CTX *mem_ctx, struct samr_Password *pwd, uint16
 {
        char *p;
        if (pwd != NULL) {
-               int i;
                p = talloc_array(mem_ctx, char, 33);
                if (!p) {
                        return NULL;
                }
-
-               for (i = 0; i < sizeof(pwd->hash); i++)
-                       slprintf(&p[i*2], 3, "%02X", pwd->hash[i]);
+               hex_encode_buf(p, pwd->hash, sizeof(pwd->hash));
        } else {
                if (acb_info & ACB_PWNOTREQ)
                        p = talloc_strdup(mem_ctx, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX");