]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
decode/pppoe: CDPCP as a known protocol
authorThomas Winter <Thomas.Winter@alliedtelesis.co.nz>
Wed, 23 Jul 2025 23:58:31 +0000 (11:58 +1200)
committerVictor Julien <victor@inliniac.net>
Mon, 8 Sep 2025 16:47:11 +0000 (18:47 +0200)
Cisco Discovery Protocol Control Protocol may be sent over pppoe.
We should allow it to help network functions.

src/decode-ppp.c
src/decode-ppp.h
src/decode-pppoe.c

index 7d502e290e218e09fc57c715b26f6af075ce430c..8820e1121a805e7b92ccfaa8825b79790dc0b552 100644 (file)
@@ -138,6 +138,7 @@ static int DecodePPPUncompressedProto(ThreadVars *tv, DecodeThreadVars *dtv, Pac
         case PPP_LQM:
         case PPP_CBCP:
         case PPP_COMP_DGRAM:
+        case PPP_CDPCP:
             /* Valid types to be in PPP but don't inspect validity. */
             return TM_ECODE_OK;
 
index a5ed9766d593dcb77ccb42e964e043017d193210..caefd413233549cd90d03693d9e85a24351cf900 100644 (file)
@@ -54,6 +54,7 @@
 #define PPP_STIICP     0x8033 /* Stream Protocol Control Protocol */
 #define PPP_VINESCP    0x8035 /* Banyan Vines Control Protocol */
 #define PPP_IPV6CP     0x8057 /* IPv6 Control Protocol */
+#define PPP_CDPCP      0x8207 /* Cisco Discovery Protocol Control Protocol */
 #define PPP_MPLSCP     0x8281 /* rfc 3022 */
 #define PPP_LCP        0xc021 /* Link Control Protocol */
 #define PPP_PAP        0xc023 /* Password Authentication Protocol */
index bf138878465c019981302c515ae365c53fd7c088..d5998f9d819fd2f3a1a5f8d199ab52a2dc90d6bc 100644 (file)
@@ -199,6 +199,7 @@ int DecodePPPOESession(
             case PPP_LQM:
             case PPP_CBCP:
             case PPP_COMP_DGRAM:
+            case PPP_CDPCP:
                 /* Valid types to be in PPP but don't inspect validity. */
                 break;