]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-sql: driver-cassandra - Use INTx_MIN and INTx_MAX
authorAki Tuomi <aki.tuomi@open-xchange.com>
Fri, 28 Aug 2020 10:17:10 +0000 (13:17 +0300)
committeraki.tuomi <aki.tuomi@open-xchange.com>
Fri, 11 Sep 2020 05:31:07 +0000 (05:31 +0000)
Preferred over magic numbers

src/lib-sql/driver-cassandra.c

index 07ff5fdb9f4df48ed7186ae0d8bf630dc395be3e..ee39b85fa5cbf8278fd28b16f7db95a7998c8a0a 100644 (file)
@@ -1989,7 +1989,7 @@ driver_cassandra_bind_int(struct cassandra_sql_statement *stmt,
 
        switch (value_type) {
        case CASS_VALUE_TYPE_INT:
-               if (value < -2147483648 || value > 2147483647)
+               if (value < INT32_MIN || value > INT32_MAX)
                        return CASS_ERROR_LIB_INVALID_VALUE_TYPE;
                return cass_statement_bind_int32(stmt->cass_stmt, column_idx,
                                                 value);
@@ -1998,12 +1998,12 @@ driver_cassandra_bind_int(struct cassandra_sql_statement *stmt,
                return cass_statement_bind_int64(stmt->cass_stmt, column_idx,
                                                 value);
        case CASS_VALUE_TYPE_SMALL_INT:
-               if (value < -32768 || value > 32767)
+               if (value < INT16_MIN || value > INT16_MAX)
                        return CASS_ERROR_LIB_INVALID_VALUE_TYPE;
                return cass_statement_bind_int16(stmt->cass_stmt, column_idx,
                                                 value);
        case CASS_VALUE_TYPE_TINY_INT:
-               if (value < -128 || value > 127)
+               if (value < INT8_MIN || value > INT8_MAX)
                        return CASS_ERROR_LIB_INVALID_VALUE_TYPE;
                return cass_statement_bind_int8(stmt->cass_stmt, column_idx,
                                                value);