]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/arm/virt: Fix non-secure flash mode
authorDavid Engraf <david.engraf@sysgo.com>
Mon, 15 Jul 2019 13:17:04 +0000 (14:17 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 15 Jul 2019 13:17:04 +0000 (14:17 +0100)
Using the whole 128 MiB flash in non-secure mode is not working because
virt_flash_fdt() expects the same address for secure_sysmem and sysmem.
This is not correctly handled by caller because it forwards NULL for
secure_sysmem in non-secure flash mode.

Fixed by using sysmem when secure_sysmem is NULL.

Signed-off-by: David Engraf <david.engraf@sysgo.com>
Message-id: 20190712075002.14326-1-david.engraf@sysgo.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt.c

index 0b5138cb22c474295a2c9ac0f244f5747448a3a7..d9496c9363421a74525ab83deda0355a2663d4b7 100644 (file)
@@ -1674,7 +1674,7 @@ static void machvirt_init(MachineState *machine)
                                     &machine->device_memory->mr);
     }
 
-    virt_flash_fdt(vms, sysmem, secure_sysmem);
+    virt_flash_fdt(vms, sysmem, secure_sysmem ?: sysmem);
 
     create_gic(vms, pic);