]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 22 Jan 2025 07:18:13 +0000 (10:18 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 22 Jan 2025 08:28:42 +0000 (09:28 +0100)
Propagate the error code from devm_gpiod_get_index_optional().  The
current code returns success.

Fixes: bb5f86ea50ff ("ALSA: hda/tas2781: Add tas2781 hda SPI driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/6103e81a-13bf-4eab-89af-f6830c14e14c@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/tas2781_hda_spi.c

index 02794fd6003d9b63872b23a5cea5a7fe06737156..eba9c3a3b944445163674ea122381a8b1849d2dc 100644 (file)
@@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda,
                p->reset = devm_gpiod_get_index_optional(physdev, "reset",
                        p->index, GPIOD_OUT_LOW);
                if (IS_ERR(p->reset)) {
+                       ret = PTR_ERR(p->reset);
                        dev_err_probe(p->dev, ret, "Failed on reset GPIO\n");
                        goto err;
                }