]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
macsec: remove validate_add_rxsc
authorSabrina Dubroca <sd@queasysnail.net>
Tue, 26 Aug 2025 13:16:25 +0000 (15:16 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 Aug 2025 01:34:53 +0000 (18:34 -0700)
It's not doing much anymore.

Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/218147f2f11cab885abc86b779dcefcd3208a2f8.1756202772.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/macsec.c

index 83158dbc16280db7eedda097016cc71509cf11ec..ca47c9a95cf49c529ace73c4810d994cb211a3a7 100644 (file)
@@ -1864,14 +1864,6 @@ cleanup:
        return err;
 }
 
-static bool validate_add_rxsc(struct nlattr **attrs)
-{
-       if (!attrs[MACSEC_RXSC_ATTR_SCI])
-               return false;
-
-       return true;
-}
-
 static int macsec_add_rxsc(struct sk_buff *skb, struct genl_info *info)
 {
        struct net_device *dev;
@@ -1889,7 +1881,7 @@ static int macsec_add_rxsc(struct sk_buff *skb, struct genl_info *info)
        if (parse_rxsc_config(attrs, tb_rxsc))
                return -EINVAL;
 
-       if (!validate_add_rxsc(tb_rxsc))
+       if (!tb_rxsc[MACSEC_RXSC_ATTR_SCI])
                return -EINVAL;
 
        rtnl_lock();
@@ -2487,7 +2479,7 @@ static int macsec_upd_rxsc(struct sk_buff *skb, struct genl_info *info)
        if (parse_rxsc_config(attrs, tb_rxsc))
                return -EINVAL;
 
-       if (!validate_add_rxsc(tb_rxsc))
+       if (!tb_rxsc[MACSEC_RXSC_ATTR_SCI])
                return -EINVAL;
 
        rtnl_lock();