Fix redundant error messages in client tools

A few client tools duplicate error messages already provided by libpq.

Discussion: https://www.postgresql.org/message-id/flat/3e937641-88a1-e697-612e-99bba4b8e5e4%40enterprisedb.com

diff --git a/src/bin/pg_basebackup/streamutil.c b/src/bin/pg_basebackup/streamutil.c
index 8ef133d119cb3b13fc74c02e4bac730ab103478d..1d59b5a4f00a09f95462a44b6d26f7df0c81275a 100644 (file)
--- a/src/bin/pg_basebackup/streamutil.c
+++ b/src/bin/pg_basebackup/streamutil.c
@@ -193,8 +193,7 @@ GetConnection(void)
 
        if (PQstatus(tmpconn) != CONNECTION_OK)
        {
-               fprintf(stderr, _("%s: could not connect to server: %s"),
-                               progname, PQerrorMessage(tmpconn));
+               fprintf(stderr, _("%s: %s"), progname, PQerrorMessage(tmpconn));
                PQfinish(tmpconn);
                free(values);
                free(keywords);

diff --git a/src/bin/pg_rewind/libpq_fetch.c b/src/bin/pg_rewind/libpq_fetch.c
index f599811411bcba067ba7bf360d149f18b7584438..9344655f2b38f79c2fdc752b8b0bf5f1c657a464 100644 (file)
--- a/src/bin/pg_rewind/libpq_fetch.c
+++ b/src/bin/pg_rewind/libpq_fetch.c
@@ -55,8 +55,7 @@ libpqConnect(const char *connstr)
 
        conn = PQconnectdb(connstr);
        if (PQstatus(conn) == CONNECTION_BAD)
-               pg_fatal("could not connect to server: %s",
-                                PQerrorMessage(conn));
+               pg_fatal("%s", PQerrorMessage(conn));
 
        pg_log(PG_PROGRESS, "connected to server\n");