]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Remove bare "except" from disassembler.py
authorTom Tromey <tromey@adacore.com>
Tue, 19 Mar 2024 16:49:20 +0000 (10:49 -0600)
committerTom Tromey <tromey@adacore.com>
Tue, 2 Apr 2024 16:58:37 +0000 (10:58 -0600)
flake8 complains about a bare "except" in disassembler.py.  In this
case, the code purports to guard against some kind of user error
involving data structure corruption.  I think it's better here to just
let the error occur -- py-disasm.c will show a stack trace in this
case.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
gdb/python/lib/gdb/disassembler.py

index ecf42688ae978ebd75c41246b287bca826d71702..2d313ae2122bdb1c81d196033b9a9e7776fe85f4 100644 (file)
@@ -93,21 +93,14 @@ def _print_insn(info):
     disassembled."""
 
     def lookup_disassembler(arch):
-        try:
-            name = arch.name()
-            if name is None:
-                return None
-            if name in _disassemblers_dict:
-                return _disassemblers_dict[name]
-            if None in _disassemblers_dict:
-                return _disassemblers_dict[None]
-            return None
-        except:
-            # It's pretty unlikely this exception case will ever
-            # trigger, one situation would be if the user somehow
-            # corrupted the _disassemblers_dict variable such that it
-            # was no longer a dictionary.
+        name = arch.name()
+        if name is None:
             return None
+        if name in _disassemblers_dict:
+            return _disassemblers_dict[name]
+        if None in _disassemblers_dict:
+            return _disassemblers_dict[None]
+        return None
 
     disassembler = lookup_disassembler(info.architecture)
     if disassembler is None: