]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dmaengine: mediatek: drop unused variable
authorVinod Koul <vkoul@kernel.org>
Thu, 15 May 2025 10:42:13 +0000 (11:42 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 15 May 2025 10:42:13 +0000 (11:42 +0100)
Commit 157ae5ffd76a dmaengine: mediatek: Fix a possible deadlock error
in mtk_cqdma_tx_status() fixed locks but kept unused varibale leading to
warning and build failure (due to warning treated as errors)

drivers/dma/mediatek/mtk-cqdma.c: In function 'mtk_cqdma_find_active_desc':
drivers/dma/mediatek/mtk-cqdma.c:423:23: error: unused variable 'flags' [-Werror=unused-variable]
  423 |         unsigned long flags;
      |                       ^~~~~

Fix by dropping this unused flag

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 157ae5ffd76a ("dmaengine: mediatek: Fix a possible deadlock error in mtk_cqdma_tx_status()")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mediatek/mtk-cqdma.c

index e35271ac1eed2a236f81a509fbcf8fe25282a06e..47c8adfdc15504bf37f4f007e65abe7aa56a99da 100644 (file)
@@ -420,7 +420,6 @@ static struct virt_dma_desc *mtk_cqdma_find_active_desc(struct dma_chan *c,
 {
        struct mtk_cqdma_vchan *cvc = to_cqdma_vchan(c);
        struct virt_dma_desc *vd;
-       unsigned long flags;
 
        list_for_each_entry(vd, &cvc->pc->queue, node)
                if (vd->tx.cookie == cookie) {