]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
asus-laptop: prefer strscpy() over strcpy()
authorAbdul Rahim <abdul.rahim@myyahoo.com>
Wed, 9 Oct 2024 23:05:58 +0000 (04:35 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 10 Oct 2024 10:30:46 +0000 (13:30 +0300)
The function strcpy() is depreciated and potentially unsafe. It performs
no bounds checking on the destination buffer. This could result in
linear overflows beyond the end of the buffer, leading to all kinds of
misbehaviors. The safe replacement is strscpy() [1].

this fixes checkpatch warning:
    WARNING: Prefer strscpy over strcpy

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
Signed-off-by: Abdul Rahim <abdul.rahim@myyahoo.com>
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241009230558.51892-1-abdul.rahim@myyahoo.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/asus-laptop.c

index 9d7e6b712abf11655e997f84770679427de87837..d460dd194f19656db1b6c088f91e9adaca4d2aee 100644 (file)
@@ -1832,8 +1832,8 @@ static int asus_acpi_add(struct acpi_device *device)
        if (!asus)
                return -ENOMEM;
        asus->handle = device->handle;
-       strcpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME);
-       strcpy(acpi_device_class(device), ASUS_LAPTOP_CLASS);
+       strscpy(acpi_device_name(device), ASUS_LAPTOP_DEVICE_NAME);
+       strscpy(acpi_device_class(device), ASUS_LAPTOP_CLASS);
        device->driver_data = asus;
        asus->device = device;