]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
leds: st1202: Check for error code from devm_mutex_init() call
authorThomas Weißschuh <linux@weissschuh.net>
Tue, 4 Feb 2025 06:52:50 +0000 (07:52 +0100)
committerLee Jones <lee@kernel.org>
Tue, 11 Feb 2025 13:41:00 +0000 (13:41 +0000)
Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: 259230378c65 ("leds: Add LED1202 I2C driver")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20250204-must_check-devm_mutex_init-v2-1-7b6271c4b7e6@weissschuh.net
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-st1202.c

index b691c4886993f3e371e857543863c9a724742f39..657c62cb24fa726622369fc965fa7195e73170f0 100644 (file)
@@ -356,7 +356,9 @@ static int st1202_probe(struct i2c_client *client)
        if (!chip)
                return -ENOMEM;
 
-       devm_mutex_init(&client->dev, &chip->lock);
+       ret = devm_mutex_init(&client->dev, &chip->lock);
+       if (ret < 0)
+               return ret;
        chip->client = client;
 
        ret = st1202_dt_init(chip);