]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: dwc: ep: Return -ENOMEM for allocation failures
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 5 Mar 2025 15:00:07 +0000 (18:00 +0300)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Fri, 14 Mar 2025 16:13:03 +0000 (16:13 +0000)
If the bitmap or memory allocations fail, then dw_pcie_ep_init_registers()
will incorrectly return a success.

Return -ENOMEM instead.

Fixes: 869bc5253406 ("PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/36dcb6fc-f292-4dd5-bd45-a8c6f9dc3df7@stanley.mountain
drivers/pci/controller/dwc/pcie-designware-ep.c

index 11ff292ca87de4a665942d1b957ce97a6212a7a5..2212609632c4e4aed1e49621d7764f39c1fbc5da 100644 (file)
@@ -774,6 +774,7 @@ int dw_pcie_ep_init_registers(struct dw_pcie_ep *ep)
        if (ret)
                return ret;
 
+       ret = -ENOMEM;
        if (!ep->ib_window_map) {
                ep->ib_window_map = devm_bitmap_zalloc(dev, pci->num_ib_windows,
                                                       GFP_KERNEL);