]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mfd: max14577: Fix Wvoid-pointer-to-enum-cast warning (again)
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 6 Jun 2024 14:36:46 +0000 (16:36 +0200)
committerLee Jones <lee@kernel.org>
Thu, 4 Jul 2024 16:38:40 +0000 (17:38 +0100)
'type' is an enum, thus cast of pointer on 64-bit compile test with
clang and W=1 causes:

  max14577.c:400:23: error: cast to smaller integer type 'enum maxim_device_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

Year ago this was solved, although LKML discussion suggested warning is
not suitable for kernel.  Nothing changed in this regard for a year, so
assume the warning will stay and we want to have warnings-free builds.

Link: https://lore.kernel.org/all/20230814160457.GA2836@dev-arch.thelio-3990X/
Link: https://lore.kernel.org/all/20230810095849.123321-1-krzysztof.kozlowski@linaro.org/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240606143648.152668-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/max14577.c

index 8f7472c7600988086efe2b2af6000375f99828fe..67bf4de4c0c1f42715269dbf4e8b79434437d300 100644 (file)
@@ -397,7 +397,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c)
                return ret;
        }
 
-       max14577->dev_type = (enum maxim_device_type)i2c_get_match_data(i2c);
+       max14577->dev_type = (kernel_ulong_t)i2c_get_match_data(i2c);
 
        max14577_print_dev_type(max14577);