]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: imx: Drop critical trip check from imx_set_trip_temp()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 2 Jul 2024 14:43:36 +0000 (16:43 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 10 Jul 2024 11:33:33 +0000 (13:33 +0200)
Because the IMX thermal driver does not flag its critical trip as
writable, imx_set_trip_temp() will never be invoked for it and so the
critical trip check can be dropped from there.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2272035.iZASKD2KPV@rjwysocki.net
drivers/thermal/imx_thermal.c

index 83eaae5ca3b8ace566079ba270731adee1b76bb9..c90f28ee4698942a09b601da01f73d162a29d4bf 100644 (file)
@@ -335,21 +335,12 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, int trip_id,
                             int temp)
 {
        struct imx_thermal_data *data = thermal_zone_device_priv(tz);
-       struct thermal_trip trip;
        int ret;
 
        ret = pm_runtime_resume_and_get(data->dev);
        if (ret < 0)
                return ret;
 
-       ret = __thermal_zone_get_trip(tz, trip_id, &trip);
-       if (ret)
-               return ret;
-
-       /* do not allow changing critical threshold */
-       if (trip.type == THERMAL_TRIP_CRITICAL)
-               return -EPERM;
-
        /* do not allow passive to be set higher than critical */
        if (temp < 0 || temp > trips[IMX_TRIP_CRITICAL].temperature)
                return -EINVAL;