]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
apps.c: fix error messages (newline and needless text) in load_key_certs_crls()
authorDr. David von Oheimb <David.von.Oheimb@siemens.com>
Thu, 3 Aug 2023 14:52:49 +0000 (16:52 +0200)
committerHugo Landau <hlandau@openssl.org>
Tue, 5 Sep 2023 10:47:59 +0000 (11:47 +0100)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21659)

apps/lib/apps.c

index 1acc991bb821e73257ff624dccb0795593c4e25e..824ef16c2c11a358f0fd8c58318cdc52a901b555 100644 (file)
@@ -987,7 +987,7 @@ int load_key_certs_crls(const char *uri, int format, int maybe_stdin,
 
         if (!maybe_stdin) {
             if (!quiet)
-                BIO_printf(bio_err, "No filename or uri specified for loading");
+                BIO_printf(bio_err, "No filename or uri specified for loading\n");
             goto end;
         }
         uri = "<stdin>";
@@ -1003,11 +1003,8 @@ int load_key_certs_crls(const char *uri, int format, int maybe_stdin,
         ctx = OSSL_STORE_open_ex(uri, libctx, propq, get_ui_method(), &uidata,
                                  params, NULL, NULL);
     }
-    if (ctx == NULL) {
-        if (!quiet)
-            BIO_printf(bio_err, "Could not open file or uri for loading");
+    if (ctx == NULL)
         goto end;
-    }
     if (expect > 0 && !OSSL_STORE_expect(ctx, expect))
         goto end;