]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: dwc3: imx8mp: simplify with dev_err_probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 14 Aug 2024 10:35:41 +0000 (12:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 3 Sep 2024 07:52:45 +0000 (09:52 +0200)
Use dev_err_probe() to make the error paths a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20240814-b4-cleanup-h-of-node-put-usb-v1-5-95481b9682bc@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-imx8mp.c

index 8c91e595d3b9e8818220dd415bb34e6ddc43b8fe..869b5e7c15edb93873a25540d8ba9b454035916c 100644 (file)
@@ -179,18 +179,14 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
        }
 
        dwc3_imx->hsio_clk = devm_clk_get_enabled(dev, "hsio");
-       if (IS_ERR(dwc3_imx->hsio_clk)) {
-               err = PTR_ERR(dwc3_imx->hsio_clk);
-               dev_err(dev, "Failed to get hsio clk, err=%d\n", err);
-               return err;
-       }
+       if (IS_ERR(dwc3_imx->hsio_clk))
+               return dev_err_probe(dev, PTR_ERR(dwc3_imx->hsio_clk),
+                                    "Failed to get hsio clk\n");
 
        dwc3_imx->suspend_clk = devm_clk_get_enabled(dev, "suspend");
-       if (IS_ERR(dwc3_imx->suspend_clk)) {
-               err = PTR_ERR(dwc3_imx->suspend_clk);
-               dev_err(dev, "Failed to get suspend clk, err=%d\n", err);
-               return err;
-       }
+       if (IS_ERR(dwc3_imx->suspend_clk))
+               return dev_err_probe(dev, PTR_ERR(dwc3_imx->suspend_clk),
+                                    "Failed to get suspend clk\n");
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)