]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thermal: intel: int340x: Cleanup of DLVR sysfs on driver remove
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Wed, 19 Jun 2024 12:45:58 +0000 (05:45 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 21 Jun 2024 13:20:28 +0000 (15:20 +0200)
When only DLVR enabled without DVFS, during driver remove,
proc_thermal_rfim_remove() is not called. Hence the DLVR sysfs is not
deleted.

On Lunar Lake DLVR is enabled without DVFS, hence this issue can be
reproduced.

Check also PROC_THERMAL_FEATURE_DLVR to call proc_thermal_rfim_remove().

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20240619124600.491168-2-srinivas.pandruvada@linux.intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/processor_thermal_device.c

index d75fae7b7ed22bff012fd8bd8927aa5a6124280e..7c46dd6bee731eaec4659a179a59681cfd7a91d3 100644 (file)
@@ -440,7 +440,8 @@ void proc_thermal_mmio_remove(struct pci_dev *pdev, struct proc_thermal_device *
                proc_thermal_rapl_remove();
 
        if (proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_FIVR ||
-           proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_DVFS)
+           proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_DVFS ||
+           proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_DLVR)
                proc_thermal_rfim_remove(pdev);
 
        if (proc_priv->mmio_feature_mask & PROC_THERMAL_FEATURE_POWER_FLOOR)