net_tstamp: add SCM_TS_OPT_ID for RAW sockets

The last type of sockets which supports SOF_TIMESTAMPING_OPT_ID is RAW
sockets. To add new option this patch converts all callers (direct and
indirect) of _sock_tx_timestamp to provide sockcm_cookie instead of
tsflags. And while here fix __sock_tx_timestamp to receive tsflags as
__u32 instead of __u16.

Reviewed-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Signed-off-by: Vadim Fedorenko <vadfed@meta.com>
Link: https://patch.msgid.link/20241001125716.2832769-3-vadfed@meta.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/include/net/sock.h b/include/net/sock.h
index ccf28c2b70b1e353ceeba5e485233d70b3a89190..e282127092aba205c038046e1e8078cf2582c075 100644 (file)
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -2660,39 +2660,48 @@ static inline void sock_recv_cmsgs(struct msghdr *msg, struct sock *sk,
                sock_write_timestamp(sk, 0);
 }
 
-void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags);
+void __sock_tx_timestamp(__u32 tsflags, __u8 *tx_flags);
 
 /**
  * _sock_tx_timestamp - checks whether the outgoing packet is to be time stamped
  * @sk:                socket sending this packet
- * @tsflags:   timestamping flags to use
+ * @sockc:     pointer to socket cmsg cookie to get timestamping info
  * @tx_flags:  completed with instructions for time stamping
  * @tskey:      filled in with next sk_tskey (not for TCP, which uses seqno)
  *
  * Note: callers should take care of initial ``*tx_flags`` value (usually 0)
  */
-static inline void _sock_tx_timestamp(struct sock *sk, __u16 tsflags,
+static inline void _sock_tx_timestamp(struct sock *sk,
+                                     const struct sockcm_cookie *sockc,
                                      __u8 *tx_flags, __u32 *tskey)
 {
+       __u32 tsflags = sockc->tsflags;
+
        if (unlikely(tsflags)) {
                __sock_tx_timestamp(tsflags, tx_flags);
                if (tsflags & SOF_TIMESTAMPING_OPT_ID && tskey &&
-                   tsflags & SOF_TIMESTAMPING_TX_RECORD_MASK)
-                       *tskey = atomic_inc_return(&sk->sk_tskey) - 1;
+                   tsflags & SOF_TIMESTAMPING_TX_RECORD_MASK) {
+                       if (tsflags & SOCKCM_FLAG_TS_OPT_ID)
+                               *tskey = sockc->ts_opt_id;
+                       else
+                               *tskey = atomic_inc_return(&sk->sk_tskey) - 1;
+               }
        }
        if (unlikely(sock_flag(sk, SOCK_WIFI_STATUS)))
                *tx_flags |= SKBTX_WIFI_STATUS;
 }
 
-static inline void sock_tx_timestamp(struct sock *sk, __u16 tsflags,
+static inline void sock_tx_timestamp(struct sock *sk,
+                                    const struct sockcm_cookie *sockc,
                                     __u8 *tx_flags)
 {
-       _sock_tx_timestamp(sk, tsflags, tx_flags, NULL);
+       _sock_tx_timestamp(sk, sockc, tx_flags, NULL);
 }
 
-static inline void skb_setup_tx_timestamp(struct sk_buff *skb, __u16 tsflags)
+static inline void skb_setup_tx_timestamp(struct sk_buff *skb,
+                                         const struct sockcm_cookie *sockc)
 {
-       _sock_tx_timestamp(skb->sk, tsflags, &skb_shinfo(skb)->tx_flags,
+       _sock_tx_timestamp(skb->sk, sockc, &skb_shinfo(skb)->tx_flags,
                           &skb_shinfo(skb)->tskey);
 }
 

diff --git a/net/can/raw.c b/net/can/raw.c
index 00533f64d69d52a7bb55999444c09967d5d753c9..255c0a8f39d6bae2e14b6e8a0f1d1a0a2d2a1e99 100644 (file)
--- a/net/can/raw.c
+++ b/net/can/raw.c
@@ -966,7 +966,7 @@ static int raw_sendmsg(struct socket *sock, struct msghdr *msg, size_t size)
        skb->mark = READ_ONCE(sk->sk_mark);
        skb->tstamp = sockc.transmit_time;
 
-       skb_setup_tx_timestamp(skb, sockc.tsflags);
+       skb_setup_tx_timestamp(skb, &sockc);
 
        err = can_send(skb, ro->loopback);
 

diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 0c7049f5036920933cf97953235c166a4090ba50..e5c55a95063dd8340f9a014102408e859b4eb755 100644 (file)
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -1331,7 +1331,7 @@ static int ip_setup_cork(struct sock *sk, struct inet_cork *cork,
        cork->priority = ipc->priority;
        cork->transmit_time = ipc->sockc.transmit_time;
        cork->tx_flags = 0;
-       sock_tx_timestamp(sk, ipc->sockc.tsflags, &cork->tx_flags);
+       sock_tx_timestamp(sk, &ipc->sockc, &cork->tx_flags);
        if (ipc->sockc.tsflags & SOCKCM_FLAG_TS_OPT_ID) {
                cork->flags |= IPCORK_TS_OPT_ID;
                cork->ts_opt_id = ipc->sockc.ts_opt_id;

diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 474dfd263c8bcc440c9a8340a5157a063690d04d..0e9e01967ec9411b92595aaffd0a0895711fbb1f 100644 (file)
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -370,7 +370,7 @@ static int raw_send_hdrinc(struct sock *sk, struct flowi4 *fl4,
 
        skb->ip_summed = CHECKSUM_NONE;
 
-       skb_setup_tx_timestamp(skb, sockc->tsflags);
+       skb_setup_tx_timestamp(skb, sockc);
 
        if (flags & MSG_CONFIRM)
                skb_set_dst_pending_confirm(skb, 1);

diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 4f77bd862e957f865eb919a30475c929da369792..82cc4a5633ceeeb351e52280080a91607752ba7b 100644 (file)
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -477,15 +477,16 @@ void tcp_init_sock(struct sock *sk)
 }
 EXPORT_SYMBOL(tcp_init_sock);
 
-static void tcp_tx_timestamp(struct sock *sk, u16 tsflags)
+static void tcp_tx_timestamp(struct sock *sk, struct sockcm_cookie *sockc)
 {
        struct sk_buff *skb = tcp_write_queue_tail(sk);
+       u32 tsflags = sockc->tsflags;
 
        if (tsflags && skb) {
                struct skb_shared_info *shinfo = skb_shinfo(skb);
                struct tcp_skb_cb *tcb = TCP_SKB_CB(skb);
 
-               sock_tx_timestamp(sk, tsflags, &shinfo->tx_flags);
+               sock_tx_timestamp(sk, sockc, &shinfo->tx_flags);
                if (tsflags & SOF_TIMESTAMPING_TX_ACK)
                        tcb->txstamp_ack = 1;
                if (tsflags & SOF_TIMESTAMPING_TX_RECORD_MASK)
@@ -1321,7 +1322,7 @@ wait_for_space:
 
 out:
        if (copied) {
-               tcp_tx_timestamp(sk, sockc.tsflags);
+               tcp_tx_timestamp(sk, &sockc);
                tcp_push(sk, flags, mss_now, tp->nonagle, size_goal);
        }
 out_nopush:

diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index ff6bd8d85e9a8c83468629a3b910cf8936b4b7d9..205673179b3c2673e09fdaa23b0b6e6b2b141e1c 100644 (file)
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1401,7 +1401,7 @@ static int ip6_setup_cork(struct sock *sk, struct inet_cork_full *cork,
        cork->base.gso_size = ipc6->gso_size;
        cork->base.tx_flags = 0;
        cork->base.mark = ipc6->sockc.mark;
-       sock_tx_timestamp(sk, ipc6->sockc.tsflags, &cork->base.tx_flags);
+       sock_tx_timestamp(sk, &ipc6->sockc, &cork->base.tx_flags);
        if (ipc6->sockc.tsflags & SOCKCM_FLAG_TS_OPT_ID) {
                cork->base.flags |= IPCORK_TS_OPT_ID;
                cork->base.ts_opt_id = ipc6->sockc.ts_opt_id;

diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c
index 608fa9d05b55be40881fd09b2636b5f4ab6807eb..8476a3944a884b8176e20520077f42cb531b9b06 100644 (file)
--- a/net/ipv6/raw.c
+++ b/net/ipv6/raw.c
@@ -629,7 +629,7 @@ static int rawv6_send_hdrinc(struct sock *sk, struct msghdr *msg, int length,
 
        skb->ip_summed = CHECKSUM_NONE;
 
-       skb_setup_tx_timestamp(skb, sockc->tsflags);
+       skb_setup_tx_timestamp(skb, sockc);
 
        if (flags & MSG_CONFIRM)
                skb_set_dst_pending_confirm(skb, 1);

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index a705ec21425409dc708cf61d619545ed342b1f01..f8942062f776ca86b74ee45734b526a944e7894f 100644 (file)
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -2118,7 +2118,7 @@ retry:
        skb->priority = READ_ONCE(sk->sk_priority);
        skb->mark = READ_ONCE(sk->sk_mark);
        skb_set_delivery_type_by_clockid(skb, sockc.transmit_time, sk->sk_clockid);
-       skb_setup_tx_timestamp(skb, sockc.tsflags);
+       skb_setup_tx_timestamp(skb, &sockc);
 
        if (unlikely(extra_len == 4))
                skb->no_fcs = 1;
@@ -2650,7 +2650,7 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb,
        skb->priority = READ_ONCE(po->sk.sk_priority);
        skb->mark = READ_ONCE(po->sk.sk_mark);
        skb_set_delivery_type_by_clockid(skb, sockc->transmit_time, po->sk.sk_clockid);
-       skb_setup_tx_timestamp(skb, sockc->tsflags);
+       skb_setup_tx_timestamp(skb, sockc);
        skb_zcopy_set_nouarg(skb, ph.raw);
 
        skb_reserve(skb, hlen);
@@ -3115,7 +3115,7 @@ static int packet_snd(struct socket *sock, struct msghdr *msg, size_t len)
                goto out_free;
        }
 
-       skb_setup_tx_timestamp(skb, sockc.tsflags);
+       skb_setup_tx_timestamp(skb, &sockc);
 
        if (!vnet_hdr.gso_type && (len > dev->mtu + reserve + extra_len) &&
            !packet_extra_vlan_len_allowed(dev, skb)) {

diff --git a/net/socket.c b/net/socket.c
index 601ad74930efb01384fa955a331d3221c4ff5f0e..3b1b65b9f471b5c540f559680c343cc7fead4d30 100644 (file)
--- a/net/socket.c
+++ b/net/socket.c
@@ -687,7 +687,7 @@ void sock_release(struct socket *sock)
 }
 EXPORT_SYMBOL(sock_release);
 
-void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags)
+void __sock_tx_timestamp(__u32 tsflags, __u8 *tx_flags)
 {
        u8 flags = *tx_flags;