]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: bridge: fix direct access to bridge vlan_enabled and use helper
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fri, 23 Mar 2018 16:27:06 +0000 (18:27 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Mar 2018 16:41:14 +0000 (12:41 -0400)
We need to use br_vlan_enabled() helper otherwise we'll break builds
without bridge vlans:
net/bridge//br_if.c: In function ‘br_mtu’:
net/bridge//br_if.c:458:8: error: ‘const struct net_bridge’ has no
member named ‘vlan_enabled’
  if (br->vlan_enabled)
        ^
net/bridge//br_if.c:462:1: warning: control reaches end of non-void
function [-Wreturn-type]
 }
 ^
scripts/Makefile.build:324: recipe for target 'net/bridge//br_if.o'
failed

Fixes: 419d14af9e07 ("bridge: Allow max MTU when multiple VLANs present")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_if.c

index 48dc4d2e2be3af69db13b4662424c421af5982fc..87b2afd455c7f7fa2e720672741e0dd2d85fe244 100644 (file)
@@ -455,7 +455,7 @@ static int __br_mtu(const struct net_bridge *br, bool (compare_fn)(int, int))
 
 int br_mtu(const struct net_bridge *br)
 {
-       if (br->vlan_enabled)
+       if (br_vlan_enabled(br->dev))
                return __br_mtu(br, max_mtu);
        else
                return __br_mtu(br, min_mtu);