]> git.ipfire.org Git - thirdparty/public-inbox.git/commitdiff
projects / thirdparty / public-inbox.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 246d737)
repobrowse: log: trim down unnecessary links
authorEric Wong <e@80x24.org>
Mon, 4 Jan 2016 21:31:56 +0000 (21:31 +0000)
committerEric Wong <e@80x24.org>
Tue, 5 Apr 2016 18:58:27 +0000 (18:58 +0000)
We do not need to show links to follow a commit if its parents
exist, since we will show unfollowed parents at the end of the
commit.

lib/PublicInbox/RepoBrowseGitLog.pm patch | blob | blame | history

diff --git a/lib/PublicInbox/RepoBrowseGitLog.pm b/lib/PublicInbox/RepoBrowseGitLog.pm
index 8a9ad3cb1dcb92b8c259200c3e0b165803b70ee1..9192c7fc1ac37702f4ab339dc4eb283d331d7e36 100644 (file)
--- a/lib/PublicInbox/RepoBrowseGitLog.pm
+++ b/lib/PublicInbox/RepoBrowseGitLog.pm
@@ -58,7 +58,7 @@ sub git_log_stream {
        my $rel = $req->{relcmd};
        $fh->write('<html><head>' . PublicInbox::Hval::STYLE .
                "<title>$desc</title></head><body><pre><b>$desc</b>\n\n".
-               qq!follow log\t$x\n!);
+               qq!commit\t\t$x\n!);
        $fh->write($showmsg ? '</pre>' : "\n");
        my %acache;
        local $/ = "\0\0\n";
@@ -82,18 +82,11 @@ sub git_log_stream {
                        $b =~ s/\s*\z//s;
 
                        my $ah = $acache{$an} ||= utf8_html($an);
-                       my $x = "<table><tr><td\nvalign=top><pre>";
-                       if (@p && $nr) {
-                               $x .= qq(<a\nhref="?h=$id$showmsg">$id</a>);
-                       } else {
-                               $x .= $id;
-                       }
-                       my $nl = $b eq '' ? '' : "\n";
+                       my $x = "<table><tr><td\nvalign=top><pre>$id";
+                       my $nl = $b eq '' ? '' : "\n"; # empty bodies :<
                        $b = $x . '  </pre></td><td><pre>' .
                                "<b>$s</b>\n- $ah @ $ai\n$nl" .
                                utf8_html($b) . '</pre></td></tr></table>';
-               } elsif (@p && $nr) {
-                       $b = qq(<a\nhref="?h=$id$showmsg">$id</a>\t$s\n);
                } else {
                        $b = qq($id\t$s\n);
                }
@@ -115,7 +108,7 @@ sub git_log_stream {
        if ($np == 0) {
                $foot .= "No commits follow";
        } elsif ($np > 1) {
-               $foot .= "Parent commits to follow (multiple choice):\n";
+               $foot .= "Unseen parent commits to follow (multiple choice):\n";
        } else {
                $foot .= "Next parent to follow:\n";
        }
Mirror of https://public-inbox.org/public-inbox.git/